Skip to content

fix(github): Prevent AttributeError from null webhook fields #121037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Draft

fix(github): Prevent AttributeError from null webhook fields #121037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/sentry/integrations/github/webhook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def __call__(


def get_github_external_id(event: Mapping[str, Any], host: str | None = None) -> str | None:
external_id: str | None = event.get("installation", {}).get("id")
external_id: str | None = (event.get("installation") or {}).get("id")
return f"{host}:{external_id}" if host else external_id


Expand All @@ -139,8 +139,8 @@ def get_scm_stream_extra(
"""Identifiers an SCM-stream listener needs to resolve org/integration/repo context,
surfaced so listeners don't have to re-parse the raw event body."""
return {
"installation_id": event.get("installation", {}).get("id"),
"repository_id": event.get("repository", {}).get("id"),
"installation_id": (event.get("installation") or {}).get("id"),
"repository_id": (event.get("repository") or {}).get("id"),
}


Expand Down
Loading