Skip to content

fix(forms): make :project specific fields searchable #121048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 1 commit into from
Aug 3, 2026
+0 −3
Merged

fix(forms): make :project specific fields searchable #121048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions static/app/views/settings/settingsCommandPaletteActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ function isSettingsRoute(route: string): boolean {
if (!route.startsWith('/settings/')) {
return false;
}
if (route.includes(':projectId')) {
return false;
}

@cursor cursor Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field hash lost after project picker

Medium Severity

Including :projectId routes puts field entries with a hash deep-link through ProjectSettingsLayout, which calls navigateTo with only location.pathname. That drops the hash, so after the user picks a project they land on the settings page without scrolling to or focusing the matched field.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b543614. Configure here.

@cursor cursor Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ambiguous project section titles

Medium Severity

titleFromRoute only strips :orgId / account, so every newly included project route still starts with projects and becomes a section titled Projects. Distinct pages such as alerts, filters, and ownership all share that label, and the same string is reused in field keywords.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b543614. Configure here.

if (route.includes(':teamId')) {
return false;
}
Expand Down
Loading