fix(difs): Clone Objectstore-backed Proguard DIFs correctly - #121050
Open
lcian wants to merge 4 commits into
Open
fix(difs): Clone Objectstore-backed Proguard DIFs correctly#121050lcian wants to merge 4 commits into
lcian wants to merge 4 commits into
Conversation
Use the stored Objectstore copy when available so cloned DIFs follow the active double-write and exclusive-write modes.
github-actions
Bot
added
the
Scope: Backend
lcian
changed the title
lcian
changed the title
lcian
changed the title
lcian
marked this pull request as ready for review
August 3, 2026 11:19
…d-objectstore-clones
Contributor
Sentry Snapshot Testing
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an Objectstore copy exists, the ProGuard clone path now copies those bytes instead of being tied to the
-readflag.We still call into the newly updated
create_dif_from_idthat determines what kind ofProjectDebugFileto create depending on the active flags, making this consistent with the rest of theProjectDebugFilecreation methods.