fix(forms): Include :orgId in new provider form route for search - #121051
Draft
sentry[bot] wants to merge 2 commits into
Draft
fix(forms): Include :orgId in new provider form route for search#121051sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where navigating to the "New Provider" form via Settings Search resulted in a "Route not found" error.
The root cause was that the
<FormSearch>component instatic/app/views/settings/featureFlags/changeTracking/newProviderForm.tsxdefined itsrouteprop as/settings/feature-flags/change-tracking/new-provider/, omitting the required:orgIdsegment.This incomplete route was then picked up by the Settings Search index (
generatedFieldRegistry.ts), leading to an invalid URL being generated for the search result.The fix involves:
routeprop innewProviderForm.tsxto/settings/:orgId/feature-flags/change-tracking/new-provider/.generatedFieldRegistry.tsfile to reflect this change.This ensures that the Settings Search correctly registers and generates valid URLs for the "New Provider" form.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-3B75
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.