fix(org-stats): Prevent TypeError when group.totals or group.series is undefined - #121052
Draft
sentry[bot] wants to merge 2 commits into
Draft
fix(org-stats): Prevent TypeError when group.totals or group.series is undefined#121052sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Cannot read properties of undefined (reading 'sum(quantity)')(JAVASCRIPT-3B74) that occurred instatic/app/views/organizationStats/usageStatsProjects.tsxandstatic/app/views/organizationStats/mapSeriesToChart.ts.The root cause was identified as the application attempting to access
group.totals['sum(quantity)']orgroup.series['sum(quantity)']without proper null or undefined checks. Thestats_v2API can return group entries where thetotalsorseriesfields are missing (e.g., when there is no data for a specific outcome, category, or project combination).The fix involves adding optional chaining (
?.) and nullish coalescing (?? 0or?? []) to safely access these properties, ensuring that the application gracefully handles cases wheregroup.totalsorgroup.seriesmight be undefined.During the CI process, a formatting issue was identified by the
pre-commithook. This was resolved by extracting a potentially long inline expression into a separate variable to improve readability and adhere to the project's formatting standards.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-3B74
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.