Skip to content

fix(trace): Prefer transaction data EAP instead of nodestore - #121557

Merged
mjq merged 2 commits into
masterfrom
mjq/transaction-in-trace-item-details-fe
Aug 7, 2026
Merged

fix(trace): Prefer transaction data EAP instead of nodestore#121557
mjq merged 2 commits into
masterfrom
mjq/transaction-in-trace-item-details-fe

Conversation

@mjq

@mjq mjq commented Aug 7, 2026

Copy link
Copy Markdown
Member

Transaction events' contexts, extra, and breadcrumbs are now deprecated under span streaming (replaced with attributes, attributes, and logs, respectively). However, SDKs that are still sending this data should still have it visible.

These transaction fields are serialized to attributes in Relay (getsentry/relay#6286) and then emitted by the trace item details API (#121461). Use them in preference to the transaction event. We keep reading the transaction event so that data predating this data being written to EAP (Aug 6, 2026) continue to work.

Note that:

  • The Request section is now missing, whether from a transaction event or EAP. All this data is already written to attributes (from a transaction or a streaming span) so it hasn't disappeared, it's just in a new form.
  • EAP currently lacks the _meta equivalent for these fields, so we've lost annotations for redactions, etc when this data is sourced from EAP. I'm going to restore this soon (feat(transaction): Extract contexts, extra, breadcrumbs meta relay#6296), but I don't want to wait for it (better to show the data without annotations than to have no data at all).

Fixes BROWSE-673.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 94.20% 94.19% 🔴 -0.01%
Typed 134,690 134,699 🟢 +9
Untyped 8,298 8,306 🔴 +8
🔍 10 new type safety issues introduced

any-typed symbols (9 new)

File Line Detail
static/app/components/events/breadcrumbs/utils.tsx 222 meta (param(binding))
static/app/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/contexts.tsx 34 extra (param(binding))
static/app/views/performance/newTraceDetails/traceDrawer/details/span/index.tsx 480 extra (var)
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/index.tsx 145 breadcrumbMeta (var)
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/sections/additionalData.tsx 52 <pattern> (param)
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/sections/additionalData.tsx 53 extra (param(binding))
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/sections/additionalData.tsx 54 meta (param(binding))
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/sections/breadCrumbs.tsx 30 <pattern> (param)
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/sections/breadCrumbs.tsx 32 meta (param(binding))

Type assertions (as) (1 new)

File Line Detail
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/index.tsx 143 `as EntryBreadcrumbs

This is informational only and does not block the PR.

@linear-code

linear-code Bot commented Aug 7, 2026

Copy link
Copy Markdown

BROWSE-673

@mjq
mjq marked this pull request as ready for review August 7, 2026 19:48
@mjq
mjq requested review from a team as code owners August 7, 2026 19:48

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7e54359. Configure here.

@nikkikapadia nikkikapadia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mjq
mjq merged commit 51620a2 into master Aug 7, 2026
87 of 88 checks passed
@mjq
mjq deleted the mjq/transaction-in-trace-item-details-fe branch August 7, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants