Conversation
github-actions
Bot
added
the
Scope: Frontend
jaydgoss
marked this pull request as ready for review
September 17, 2026 21:14
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
AddIntegrationButton sets a static aria-label of "Add integration" on every instance, so the GitHub, GitLab and Bitbucket pills in the SCM onboarding and project creation flows all had the same accessible name and the More menu trigger was named only "More". Each pill is now named "Add" plus the provider name and the trigger is named "More providers". The static label stays the default for every other caller.
jaydgoss
force-pushed
the
jaygoss/scm-provider-pill-names
branch
from
September 17, 2026 21:23
98afc33 to
5928658
Compare
jaydgoss
changed the base branch from
master
to
jaygoss/scm-create-project-a11y
September 17, 2026 21:23
jaydgoss
added this pull request to stack #124480
September 17, 2026 21:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddIntegrationButtonsets a staticaria-labelof "Add integration" on every instance. In the SCM onboarding and project creation flows, where it renders as a provider pill, a screen reader user heard "Add integration, button" three times in a row and could not tell GitHub from GitLab from Bitbucket. The overflow menu trigger next to them was named only "More", which says nothing about what it holds.Each pill is now named "Add" plus the provider name, for example "Add GitHub", and the overflow trigger is named "More providers". Both names keep the visible text inside them so voice control users can still speak the label they see. The static "Add integration" label moves before the spread of caller props in
AddIntegrationButtonso a caller can override it, andIntegrationButtonpassesaria-labelthrough. Every other caller passes no label, so the settings pages keep the "Add integration" name they have today.