feat(explore): Add dropped-data flyout panel shell - #124836
Draft
manessaraj wants to merge 1 commit into
Draft
manessaraj wants to merge 1 commit into
manessaraj wants to merge 1 commit into
Conversation
Open a slide-over panel when a dropped-data band bucket is clicked on explore span charts. The band series now emits click events, and the chart routes them through a new onDroppedDataClick callback threaded from TimeSeriesWidgetVisualization down through ChartVisualization to the chart, which holds the selected bucket in state and renders the panel. The panel renders a header shell only (close button, divider, and title); its content is a follow-up. Refs DAIN-1868
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-f383kpaz9.sentry.dev |
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
| borderBottom="primary" | ||
| > | ||
| <Button variant="transparent" size="sm" icon={<IconClose />} onClick={onClose}> | ||
| Close |
Contributor
There was a problem hiding this comment.
This, and every text, should be wrapped around the t() fn to account for different "human" languages.
Comment applies to others of the same type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opens a slide-over panel when a user clicks a bucket in the dropped-data band on the explore span charts. This PR covers the panel shell + header only — the panel content (summary/total header, chart, per-reason tables) is a follow-up.
Notes
Refs DAIN-1868