Conversation
…board AddIntegrationButton and DirectEnableButton were natively disabled when the provider cannot be added or the user lacks access, so keyboard and screen reader users could not reach the tooltip that explains why. Both buttons are now aria-disabled with the tooltip on the button itself, and the click handler bails while disabled.
jaydgoss
added this pull request to stack #124480
September 17, 2026 21:25
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddIntegrationButtonandDirectEnableButtoneach wrap a natively disabled button in a tooltip that explains why it is disabled: the provider cannot be added from Sentry, or the user lacks permission to enable it. A natively disabled button cannot take focus, so keyboard and screen reader users never got that explanation. It was hover only.Both buttons are now
aria-disabledinstead ofdisabled, with the tooltip passed to the button's owntooltipPropsso it opens on focus as well as hover. The click handler returns early while the button is disabled, so nothing starts an install or enable request. The core Button styles in #124479 makearia-disabledlook the same asdisabled, so the visible state does not change.DirectEnableButtonkeeps nativedisabledwhile the enable request is pending and when a caller passesdisabled, since neither of those states has a tooltip to reach.The add-integration tooltip copy now goes through
t()with the provider name as a parameter. The wording is unchanged.The two specs assert
aria-disabled, reach the tooltip by focusing the button, and check that a click does not fire the request or open the modal.