Skip to content

ref(action-log): Remove legacy comment ID fallbacks from UI - #124839

Open
shashjar wants to merge 1 commit into
shashjar/restore-GALE-row-IDs-in-activity-responsesfrom
shashjar/remove-legacy-comment-ID-fallbacks
Open

shashjar wants to merge 1 commit into
shashjar/restore-GALE-row-IDs-in-activity-responsesfrom
shashjar/remove-legacy-comment-ID-fallbacks

Conversation

@shashjar

Copy link
Copy Markdown
Member

Refs https://linear.app/getsentry/issue/ISWF-3427/serialize-a-dedicated-comment-reference-field-instead-of-overloading.

PR 4/4.

Require commentId on comment activities and remove the temporary commentId ?? id fallbacks from mutations, cache updates, and React keys. Preserve activity row IDs when updating cached comments.

Update fixtures and stories, and remove the obsolete missing-reference test case while retaining coverage for distinct activity and comment IDs.

@linear-code

linear-code Bot commented Sep 17, 2026

Copy link
Copy Markdown

ISWF-3427

@shashjar
shashjar added this pull request to stack #124829 September 17, 2026 21:31
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 17, 2026
@shashjar

Copy link
Copy Markdown
Member Author

bugbot review

@github-actions

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-8h2exeeqy.sentry.dev

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0a7151d. Configure here.

@shashjar
shashjar requested review from cvxluo and kcons September 17, 2026 21:35
@shashjar
shashjar marked this pull request as ready for review September 17, 2026 21:36
@shashjar
shashjar requested review from a team as code owners September 17, 2026 21:36
@shashjar
shashjar removed request for a team September 17, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants