Conversation
Autofix moves out of the Seer drawer and onto `/issues/<id>/autofix/`, behind `organizations:autofix-page`. The route is registered among the issue tabs rather than beside them, so the page inherits the group header, event details header, page filters, sidebar and group/project context from the issue details route instead of standing them up again. Inside `IssueDetailsColumn` it renders its own section in place of the event details one: the same chrome and tab navigation, minus the event details tour, whose copy is about stack traces and tags that this tab does not show. Every existing "open Seer" entry point now resolves its destination through one helper, so the issue stream badge, the inbox preview, the browser notification and the drawer opener all land on whichever surface the flag selects. Legacy `?seerDrawer=true` links still work: they reach the drawer opener and are forwarded to the tab. The panel body itself is untouched. What the drawer used to own directly — running Autofix, the toolbar handlers, the permission warnings — moved into `useSeerPanel` and `warnings.tsx` so both surfaces share one implementation. Auto-scroll deliberately stayed with the drawer: it needs a bounded scroll container, and the tab scrolls with the page. Two earlier attempts (#124676, #124753) made this a sibling route and had to re-create `PageFiltersContainer`, `GroupIdProvider` and `IssueDetailsContextProvider` by hand; both are closed. Feature flag: `organizations:autofix-page` (already registered).
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autofix moves out of the Seer drawer and onto
/issues/<id>/autofix/, behindorganizations:autofix-page. The panel body itself is unchanged —SeerDrawerContentrenders as-is; what changes is where it lives and how you get there.Why this shape
Two earlier attempts made this a route beside
:groupId/: #124676 (variant A) and #124753 (variant B), both now closed. A sibling route sits outside the issue details scaffolding, so each one had to re-createPageFiltersContainer,GroupIdProviderandIssueDetailsContextProviderby hand, and variant B still paid four extra requests on load to put an event graph on the page.Registering the route among the issue tabs instead removes that problem rather than working around it. The page inherits the group header, event details header, page filters, sidebar and group/project context from the issue details route, and
useGroupData()hands it the group and project with no extra request.Inside
IssueDetailsColumnthe tab renders its own section in place of the event details one — the same chrome and tab navigation, minus the event details tour, whose copy is about stack traces and tags that this tab does not show. The navigation stays because it is the only way back out of the tab.Getting there
Every "open Seer" entry point now resolves its destination through one helper (
makeSeerLocation), so the issue stream badge, the inbox preview, the browser notification and the drawer opener all land on whichever surface the flag selects. Legacy?seerDrawer=truelinks keep working: they reach the drawer opener and are forwarded to the tab. An Autofix entry also appears in the issue content dropdown when the flag is on.Visiting the URL without the flag — or with
gen-ai-featuresoff, orhideAiFeaturesset — redirects back to issue details, so a shared or bookmarked link does not dead-end.Shared implementation
What the drawer used to own directly — running Autofix, the toolbar handlers, the GitHub permission warnings — moved into
useSeerPanelandwarnings.tsxso the drawer and the tab cannot drift. Auto-scroll deliberately stayed with the drawer: it needs a bounded scroll container, and the tab scrolls with the page. That is the one intentional behavior difference between the two surfaces, and the reason it is called out here rather than fixed: bounding a scroller insideGroupDetailsLayoutwould need the column's height model reworked, which is worth doing separately if the tab becomes the default.Feature flag:
organizations:autofix-page— already registered, so this PR is frontend-only.Screenshots to follow; the tab needs a Seer-enabled org to render meaningfully.