Skip to content

perf(auth): Skip full organization hydration during access checks - #124849

Draft
shashjar wants to merge 1 commit into
shashjar/iswf-3361-active-resource-idsfrom
shashjar/iswf-3361-lightweight-access
Draft

shashjar wants to merge 1 commit into
shashjar/iswf-3361-active-resource-idsfrom
shashjar/iswf-3361-lightweight-access

Conversation

@shashjar

@shashjar shashjar commented Sep 17, 2026

Copy link
Copy Markdown
Member

Access checks now request organization/member context without hydrating every project and team, including the demo-permission override. Privileged RPC-backed access resolves active project and team IDs independently, on first use, and caches each set for that access object. This removes the full model serialization identified in ISWF-3361 while preserving project visibility and the distinction between access and membership.

Deploy the ID RPCs from PR 1 to every cell before this consumer. The general organization-service hydration defaults remain available for callers that need full objects; PR 4 separately changes control endpoint defaults after the getsentry broadcast compatibility change.

Regression coverage checks ordinary membership, superusers, organization tokens, Sentry Apps, inactive and foreign resources, lazy lookup behavior, and endpoint authorization across silo modes. Lookup errors propagate rather than producing permissive access.

Part 2 of 4 for ISWF-3361. Review/deploy order: 1: ID RPCs2: access checks3: broadcasts4: control defaults.

@linear-code

linear-code Bot commented Sep 17, 2026

Copy link
Copy Markdown

ISWF-3361

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 17, 2026
@shashjar
shashjar force-pushed the shashjar/iswf-3361-lightweight-access branch from 66dffbb to 1eb9129 Compare September 17, 2026 22:23
Fetch project and team IDs lazily for RPC-backed global access, allowing permission contexts to omit full resource collections. Preserve active-resource filtering and request-local caching.

Refs ISWF-3361
@shashjar
shashjar force-pushed the shashjar/iswf-3361-lightweight-access branch from 1eb9129 to ecc1d43 Compare September 17, 2026 23:02
@shashjar
shashjar force-pushed the shashjar/iswf-3361-active-resource-ids branch from 0a3d8bd to ce90fbd Compare September 17, 2026 23:02
@sentry

sentry Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 503 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant