Skip to content

fix(alerts): Enforce project access for alert rule mappings - #124854

Open
shashjar wants to merge 1 commit into
masterfrom
shashjar/enforce-project-access-for-alert-rule-mappings
Open

shashjar wants to merge 1 commit into
masterfrom
shashjar/enforce-project-access-for-alert-rule-mappings

Conversation

@shashjar

Copy link
Copy Markdown
Member

Fixes https://linear.app/getsentry/issue/ISWF-2749/security-bug-report-idor-in-get-organizationsorgalert-rule-workflow & https://linear.app/getsentry/issue/VULN-1837/idor-in-get-organizationsorgalert-rule-workflow-allows-unauthorized.

Require access to the source project when resolving alert rule mappings through alert-rule-workflow and alert-rule-detector. Inaccessible mappings now return 404, including through the detector’s generated-ID fallback.

Authorize individual mappings before selecting a result so shared workflows cannot expose rules from restricted projects. Limit source lookups to candidate mapping IDs to avoid scanning all accessible alert mappings.

@linear-code

linear-code Bot commented Sep 17, 2026

Copy link
Copy Markdown

ISWF-2749

VULN-1837

@shashjar

Copy link
Copy Markdown
Member Author

bugbot review

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 17, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0504d4c. Configure here.

@shashjar
shashjar requested review from a team September 17, 2026 22:50
@shashjar
shashjar marked this pull request as ready for review September 17, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant