feat(np): Adds renderer for MSTeams issue alerts - #124860
Open
hobzcalvin wants to merge 3 commits into
Open
hobzcalvin wants to merge 3 commits into
hobzcalvin wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
2 times, most recently
from
September 18, 2026 22:11
cdea8d3 to
7572f39
Compare
Annotates _build_expected_card as returning an AdaptiveCard and types its actions list, resolving mypy errors in the MSTeams issue renderer tests. Co-authored-by: Cursor <cursoragent@cursor.com>
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
September 18, 2026 22:26
7572f39 to
9333505
Compare
hobzcalvin
added this pull request to stack #124985
September 18, 2026 22:41
hobzcalvin
marked this pull request as ready for review
September 18, 2026 22:43
hobzcalvin
requested review from
GabeVillalobos,
leeandher,
saponifi3d and
shayna-ch
September 18, 2026 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #124857 (
gp/add_renderer_registry). Supersedes #112890, which could not be reopened after the branch was rebased.Summary
Adds
IssueMSTeamsRenderer, so issue alerts sent through the notification platform produce the same Adaptive Card the legacyMSTeamsIssueMessageBuilderpath produces today. The renderer registers itself for(MSTEAMS, ISSUE)with the registry from the parent PR rather than adding aget_rendereroverride to the provider.Original work by @GabeVillalobos; rebased onto current master and adapted to the registry.
Notes for review
GroupandEventitself, which the comment at the top ofrendercalls out as an anti-pattern. It is deliberate for now: it lets the card be byte-identical to the legacy builder during rollout, sincebuild_attachment_title,build_footer, and friends all take ORM objects. The permanent fix is denormalizing those fields intoIssueNotificationData, the wayMetricAlertNotificationDataalready carries precomputed strings.RpcIntegrationfor action webhook routing; that is follow-up work.Test plan
pytest tests/sentry/notifications/platform/— 246 passing.IssueNotificationDatatoIssueMSTeamsRendererand falls back to the default renderer for an unregistered source.Made with Cursor