fix(teams): Allow team admins to review access requests - #124863
Draft
sentry-junior[bot] wants to merge 3 commits into
Draft
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: Ben Henry <ben.henry@sentry.io>
Contributor
Author
|
@leeandher @oioki @getsentry/foundations — could you review the team-scoped authorization changes here? This fixes listing and approving pending team access requests for granular Team Admins when open membership is disabled. |
scttcper
reviewed
Sep 18, 2026
scttcper
reviewed
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Team Admin permissions are team-scoped, but the access-request list and outer PUT permission gate required global write scopes. This allows organization members through the outer gate, then uses the existing per-team authorization check to return and mutate requests only for teams they manage.
Adds regression coverage for a member with granular Team Admin access and closed membership.
cc @wedamija @leeandher @oioki @getsentry/foundations
via dan.
--
View Junior Session [Sentry]