Skip to content

fix(teams): Allow team admins to review access requests - #124863

Draft
sentry-junior[bot] wants to merge 3 commits into
masterfrom
fix/team-admin-access-requests
Draft

sentry-junior[bot] wants to merge 3 commits into
masterfrom
fix/team-admin-access-requests

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Team Admin permissions are team-scoped, but the access-request list and outer PUT permission gate required global write scopes. This allows organization members through the outer gate, then uses the existing per-team authorization check to return and mutate requests only for teams they manage.

Adds regression coverage for a member with granular Team Admin access and closed membership.

cc @wedamija @leeandher @oioki @getsentry/foundations

via dan.

--

View Junior Session [Sentry]

Co-Authored-By: Ben Henry <ben.henry@sentry.io>
@sentry-junior
sentry-junior Bot requested a review from wedamija September 18, 2026 00:15
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 18, 2026
@sentry-junior

sentry-junior Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@leeandher @oioki @getsentry/foundations — could you review the team-scoped authorization changes here? This fixes listing and approving pending team access requests for granular Team Admins when open membership is disabled.

@sentry-junior
sentry-junior Bot requested review from a team, leeandher and oioki September 18, 2026 00:23
Comment thread src/sentry/api/endpoints/organization_access_request_details.py Outdated
Comment thread tests/sentry/api/endpoints/test_organization_access_requests.py
Comment thread src/sentry/api/endpoints/organization_access_request_details.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant