Repository navigation
ref(deps): Patch zrender to clear nodes with textContent - #125290
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
zrender's canvas and SVG painters clear their root and helper nodes by assigning to innerHTML. Assigning to innerHTML is a Trusted Types injection sink, so every chart render and dispose is rejected on a page that sets `require-trusted-types-for 'script'`. All seven writes assign an empty string, so textContent is equivalent and clears the node the same way. The remaining innerHTML in svg-legacy/Painter.js is a read, not a write, and is left alone. Submitted upstream as ecomfe/zrender#1167. Patching locally until it lands, since charts are unusable under enforcement without it.
oioki
force-pushed
the
oioki/ref/zrender-text-content
branch
from
September 23, 2026 08:29
a5d3a0f to
88868c1
Compare
oioki
marked this pull request as ready for review
September 23, 2026 08:53
| @@ -0,0 +1,83 @@ | |||
| diff --git a/lib/canvas/Painter.js b/lib/canvas/Painter.js | |||
Member
There was a problem hiding this comment.
Let's include a patch message at the top so we know why we have this?
evanpurkhiser
approved these changes
Sep 23, 2026
Says what the patch does, why it exists, when to drop it, and why the upstream PR cannot be used verbatim: it edits src/*.ts, while the published package resolves its module entry through index.js to lib/*.js, so the compiled output is what has to be patched.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zrender's canvas and SVG painters clear their root and helper nodes by assigning to
innerHTML. That is a Trusted Types injection sink, so every chart render and dispose is rejected on a page that setsrequire-trusted-types-for 'script'. Charts are the single largest source of sinks we pull in (133 occurrences across echarts/zrender), and none of them are reachable from our own code.All seven writes assign an empty string, so
textContent = ''is equivalent and clears the node the same way. The remaininginnerHTMLinsvg-legacy/Painter.jsis a read, not a write, and is left alone.Submitted upstream as ecomfe/zrender#1167. Patching locally until it lands — upstream acceptance is not on our timeline, and charts are unusable under enforcement without it.
Verified: the 13 chart suites in
static/app/components/chartspass (126 tests), and the patched files contain no remaininginnerHTMLwrites.