Repository navigation
fix(cli): Stop dashboard revisions pagination from skipping rows - #1608
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
`sentry dashboard revisions --limit 150` fetched two full pages of 100, trimmed the last 50 rows, and still stored the server cursor, so `-c next` silently skipped those 50 revisions. Later pages now request only the remaining budget, like the shared paginate() helper, and the cursor is dropped if an endpoint still returns more than requested. Ported from getsentry/cli#1118. Co-Authored-By: BYK <burak.kaya@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry dashboard revisions --limit 150fetched two full pages of 100, trimmed the last 50, and still stored the server cursor.-c nextthen silently skipped those 50 revisions.Later pages now request only the remaining budget, the same way the shared
paginate()helper does since getsentry/cli#1615. If an endpoint still returns more than requested, the cursor is dropped, matchingautoPaginate.Ported from the dashboard part of getsentry/cli#1118, which is being closed with the repo archive.
via BYK.
--
View Junior Session in Sentry