Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
betegon
marked this pull request as ready for review
October 25, 2026 21:26
betegon
force-pushed
the
fix/cli-schema-discovery
branch
from
October 25, 2026 21:44
74c333a to
c500f15
Compare
betegon
force-pushed
the
fix/cli-schema-discovery
branch
from
October 26, 2026 15:20
c500f15 to
b1bb28d
Compare
Comment on lines
+429
to
+432
| const matches = searchEndpoints(query, undefined, references); | ||
| if (matches.length > 0) { | ||
| return { kind: "endpoints", endpoints: matches }; | ||
| } |
There was a problem hiding this comment.
Method-prefixed exact IDs return an array instead of one endpoint object
sentry schema GET listOrganizationEvents (and similar METHOD + operationId/fn lookups) resolves as kind: "endpoints", so --json emits a one-element array instead of the bare endpoint object exact lookups are documented to keep.
Evidence
resolveIdentifierLookup(query)matches the raw string only, soGET listOrganizationEventsnever hits the single-endpoint branch.searchEndpoints()strips the method, exact-matcheslistOrganizationEvents, and returns a plain one-element list with nomatchmetadata.resolveResourceQuery()then always wraps anysearchEndpoints()hit as{ kind: "endpoints" }, including that single exact result.- Path and bare-identifier exact paths still return
{ kind: "endpoint" }; tests cover those shapes but not METHOD + operationId.
Identified by Warden · code-review · Y6V-GWQ
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry schemanow discovers API capabilities from OpenAPI metadata and real CLI command paths, includinglog,trace, andalert metrics. Ambiguous queries return candidates with context instead of silently choosing the first endpoint; exact lookups keep their JSON shape.Reuses command introspection and schema generation, with tests for API/CLI growth and compatibility.
Examples:
Validation: typecheck, lint, and schema tests pass. The full local suite is not green: an unchanged installer test fails on macOS, and asset-catalog tests require the unavailable
actool.