Repository navigation
feat(cli): label explore charts with shared axes and legends - #1717
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
6d17e92 to
a712d3b
Compare
BYK
left a comment
There was a problem hiding this comment.
Overall looks good, that said I think we should not repeat data visible in the legend now (the stuff about p95 for instance) and use the area more efficiently by placing text around the graph rectangle. Or at least make it more dense and after the graph so graph stays as the center of attention?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1d5a734. Configure here.
1d5a734 to
a6e62a9
Compare

Follow-up to #1693. Explore time-series images now include a value axis, UTC bucket-start labels, and a colored aggregate legend, so each chart carries its own scale and identity.
The axes and legend are extracted from the existing dashboard compositor into a shared renderer used by both commands. Explore keeps its own unit/precision formatting and UTC timestamps. Axes occupy separate pixels from the data, preserving the distinction between null/incomplete gaps and zero/tiny-value ticks.
Charts appear before compact captions containing the interval and relevant warnings. Text already shown by the axes and legend is removed; a full aggregate expression remains below the chart when the legend shortens it, and units remain explicit when the axis does not display them. The query range stays in the header, missing/incomplete values stay in their detail table, and ingestion details follow the results.
If the labels do not fit or the remaining plot width would require averaging buckets, Explore falls back to its full table. JSON, completeness metadata, and per-aggregate scales are unchanged. No new flags or dependencies.
Validation: the tiny-rate and numeric regression cases fail before the fix and pass afterward, including a narrow terminal where the redundant unit previously forced a table fallback. All 32 focused Explore/shared-legend tests pass; the 109-test graphics suite also passed after rebasing onto
cadcf27c1. Rootpnpm run tscandpnpm run lintpass. The latest full workspace run passes outside three existing local CLI failures (12,703 CLI tests passed): missing Xcodeactool, the musl installer case on macOS, and an issue-linking test. Those files are unchanged frommain; the full suite is not green locally.Terminal capture
Actual Ghostty window at 106 columns × 52 rows, running this PR's Explore formatter with synthetic data. The chart appears first, followed by a compact interval caption, missing/incomplete bucket details, and ingestion information. Axis and legend labels are no longer repeated above the chart.