Repository navigation
feat(cli): Complete --fields on org, project, release, dashboard, alert, and auth commands #1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
52def91
feat(cli): Complete --fields on org, project, release, and dashboard …
sentry-junior[bot] c2cefc4
Merge origin/main into feat/cli-fields-schemas
sentry-junior[bot] 47f50f0
fix(cli): Shape release create --dry-run output like a created release
sentry-junior[bot] 31da9a5
fix(cli): Apply --fields in every custom jsonTransform
sentry-junior[bot] 29d8afb
Merge origin/main into feat/cli-fields-schemas
sentry-junior[bot] 1129101
Merge origin/main into feat/cli-fields-schemas
sentry-junior[bot] c8c76c6
ref(cli): Derive alert output schemas from the generated @sentry/api …
sentry-junior[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metric create dry-run body schema does not match JSON output
--fieldscompletion and skill docs type dry-runbodyas the nested detector request payload, but JSON prints the flat CLI body (query,aggregate,triggers, …). Nested paths likebody.dataSourcescomplete then project empty; real flat keys are not offered.Evidence
MetricAlertCreateOutputSchematypesbodyasvCreateOrganizationProjectDetectorData.entries.bodywith description "Request body that would be sent (--dry-run)" (output-schemas.ts).alert metrics createdry-run yields the flat CLI body (name,query,aggregate,dataset,timeWindow,triggers,projects, …), notbuildDetectorBody()(create.ts; asserted increate.test.ts).createMetricAlertRule→buildDetectorBody(alerts.ts).buildFieldsFlagcompletes withextractSchemaFieldPaths(schema), so nested detector paths underbodyare offered against the flat output.Identified by Warden · code-review · 3VV-PEG