Repository navigation
Bump the client-go oracle to 56e5933 (2026-10-14) and Go to 1.25.14 - #53
Merged
Merged
Conversation
Moves the oracle from 01bd8f99f4da (2026-07-08) to current upstream master,
56e5933 ("locate: redact keys in region and request logs", #2106). That
client-go declares `go 1.25.14`, so the Go toolchain pin moves with it.
`go get` + `go mod tidy` also raise the modules client-go now requires:
kvproto b41e86365ce0 -> 121875fd9777 (2026-10-06), pd/client
4e05b9d2c2d3 -> afa43111d149, grpc 1.79.3 -> 1.82.1, plus x/* and genproto.
The roadmap and client-rules docs keep citing the old revision on purpose:
their file:line references are stated at the pins they were written against.
Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Moves the oracle from client-go
01bd8f99f4da(2026-07-08) to current upstream master56e5933("locate: redact keys in region and request logs", tikv/client-go#2106). That client-go declaresgo 1.25.14, sopins.toml[toolchain].gomoves with it —check-pins.shrequires thegodirective and the pin to be equal.go get+go mod tidyalso raise what client-go now requires: kvprotob41e86365ce0→121875fd9777(2026-10-06), pd/client4e05b9d2c2d3→afa43111d149, grpc 1.79.3 → 1.82.1, plusx/*and genproto.Not changed on purpose:
docs/parity-roadmap.mdanddocs/client-rules.mdstill name the old revision, because theirfile:linecitations are stated at the pins they were written against.Follow-up this creates: client-rust's
proto/VERSIONrecords kvprotob41e863as matching client-go — that is now one oracle revision behind.Kind of change
crates/,go/)scenarios/,ledger.toml)findings/)cluster/,Makefile,scripts/)README.md,docs/)Checklist
make checkis green (pins-check,go-check; fmt/clippy unaffected — no Rust change)PARITY_STRICT=1 make ledger, v8.5.5)Evidence
PARITY_STRICT=1 make ledgerwith client-rust at the pinnede53837d:The fork
getwyrd/client-gomaster was fast-forwarded to the same56e5933.