Repository navigation
ci(helm-e2e): run every lane whatever an earlier lane did - #366
Merged
Merged
Conversation
A failed lane skipped every later lane of the one job, so a flake in the gVisor lane hid the micro-VM lane's result. Every lane now runs once the setup succeeded and reports its own outcome; the job name is unchanged. Carries kagent-dev#71. Signed-off-by: Timo Derstappen <teemow@gmail.com>
Signed-off-by: Timo Derstappen <teemow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The lanes of helm-e2e are steps of one job, so a failed lane skips every later one; a flake in the gVisor lane hid the micro-VM lane on the same head (#365).
Change
Every
Run E2E tests (…)step runs once the setup succeeded (unless the run is cancelled) and reports its own outcome. The jobe2e-testkeeps its name; the required checks (run-tests,govulncheck,fork-ledger) are untouched. Upstream: kagent-dev#71, ledger file infork/.Closes #365