Skip to content

chore(deps-dashboard): bump react and @types/react in /dashboard - #314

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/dashboard/multi-7f19880bf6
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/dashboard/multi-7f19880bf6

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 14, 2026

Copy link
Copy Markdown
Contributor

Bumps react and @types/react. These dependencies needed to be updated together.
Updates react from 18.3.1 to 19.3.0

Release notes

Sourced from react's releases.

19.3.0 (September 9, 2026)

Below is a list of all new features, APIs, and bug fixes.

Read the React 19.3 release post for more information.

New React Features

New React DOM Features

  • browser(): a new react-dom API that returns a usable which errors during server rendering and resolves in the browser. use(browser()) inside a <Suspense> boundary marks a subtree as browser-only without reporting a recoverable error (@​gnoff: #37143, #37241)
    • Added an onBrowserBailout option to the react-dom/server APIs to observe when a subtree defers to the browser (@​gnoff #37193)

Notable changes

All Changes

React

... (truncated)

Changelog

Sourced from react's changelog.

19.3.0 (September 9, 2026)

New React Features

New React DOM Features

  • browser(): a new react-dom API that returns a usable which errors during server rendering and resolves in the browser. use(browser()) inside a <Suspense> boundary marks a subtree as browser-only without reporting a recoverable error (@​gnoff: #37143, #37241)
    • Added an onBrowserBailout option to the react-dom/server APIs to observe when a subtree defers to the browser (@​gnoff #37193)

Notable changes

All Changes

React

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by GitHub Actions, a new releaser for react since your current version.


Updates @types/react from 18.3.31 to 19.3.0

Commits

@dependabot @github

dependabot Bot commented on behalf of github Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dashboard, dependencies. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot
dependabot Bot requested a review from giauphan as a code owner September 14, 2026 07:17

@giauphan giauphan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dependabot[bot] @jules

The PR bumps react to 19 but leaves its counterpart packages behind — that's the one real problem here.

File: dashboard/package.json -> Line 22: react-dom stays at ^18.2.0 while react is bumped to ^19.3.0. React and ReactDOM must be version-matched — react-dom@18 declares a peer dependency on react@^18, so this will either fail npm install (ERESOLVE) or, with --legacy-peer-deps, break at runtime. Update react-dom to ^19.3.0 in the same commit.

File: dashboard/package.json -> Line 33: @types/react-dom stays at ^18.2.0. Same version-mismatch problem for types; bump to ^19.x alongside the runtime bump, otherwise type errors from mismatched React types (e.g. the new ref-as-prop / ReactNode changes) will surface.

File: dashboard/package.json -> Line 21: React 19 has breaking changes the diff doesn't account for — worth a quick check that the app doesn't rely on removed APIs: ReactDOM.render/hydrate (must use createRoot), defaultProps on function components, string refs, and element.type === 'class'-style internals. @testing-library/react ^16.3.3 is fine for React 19.

No security or performance concerns — it's a dependency-only change. Everything else looks good once react-dom and @types/react-dom are bumped in lockstep.

@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/dashboard/multi-7f19880bf6 branch from eee6270 to 0c59d45 Compare September 22, 2026 11:19

@giauphan giauphan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dependabot[bot] @jules

Here's my review of the pull request:

  1. Version Bump Consistency:

    • File: dashboard/package.json -> Line 19-20: The React version was bumped from 18.2.0 to 19.3.0, but React DOM remains at 18.2.0. This is inconsistent and could cause version mismatch issues. The @types/react and @types/react-dom versions should also be updated to match React 19.
  2. Peer Dependency Check:

    • The change doesn't show any peer dependency updates. If this is a major React version bump, you should verify that all other dependencies are compatible with React 19.
  3. Testing Considerations:

    • Since this is a major version bump, there should be additional testing to ensure all components work correctly with React 19. The test dependencies (@testing-library/react, @testing-library/user-event) should also be updated to their latest versions compatible with React 19.
  4. Documentation:

    • Consider adding a changelog entry or migration guide for this major version bump, especially if there are breaking changes in React 19 that might affect the application.

The rest of the changes look good - they're straightforward version updates that maintain consistency in the dependency tree.

Bumps [react](https://github.com/react/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together.

Updates `react` from 18.3.1 to 19.3.0
- [Release notes](https://github.com/react/react/releases)
- [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/react/react/commits/v19.3.0/packages/react)

Updates `@types/react` from 18.3.31 to 19.3.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-version: 19.3.0
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: react
  dependency-version: 19.3.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/dashboard/multi-7f19880bf6 branch from 0c59d45 to 112e592 Compare September 22, 2026 11:30

@giauphan giauphan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dependabot[bot] @jules

I'll review the changes in the provided unified diff for the github-review-bot project. Here's my analysis:

Correctness

  • The changes appear to be version updates for React and related dependencies. This is generally safe as long as the updates are compatible with the existing codebase.

Security

  • No security concerns are apparent in this diff. The version updates are straightforward and don't introduce any new potential vulnerabilities.

Performance

  • No performance-related issues are visible in this diff. The dependency updates are maintenance-related rather than performance-critical.

Code Quality

  • The changes are clean and well-formatted. The version updates are properly aligned and consistent across both the main dependencies and devDependencies.

Maintainability

  • The updates are good for maintainability as they:
    • Keep dependencies up-to-date
    • Maintain consistency between React and related type definitions
    • Follow semantic versioning principles

Specific Observations:

  1. React Version Update:

    • Updating from React 18 to 19 is a significant change, but the diff shows this is a coordinated update across all related packages (react-dom, @types/react, @types/react-dom)
    • This suggests the project is prepared for the React 19 changes
  2. Dependency Consistency:

    • All related packages (react, react-dom, @types/react, @types/react-dom) are being updated together
    • This helps prevent version mismatches that could cause issues
  3. Testing Setup:

    • The testing libraries (@testing-library/react, @testing-library/user-event) are also being updated
    • This ensures compatibility with the new React version

Overall Assessment:

The changes look good and appear to be well-considered updates. The version bumps are coordinated across related packages, which is a good practice. No major issues are apparent in this diff.

If everything else in the PR looks good, these changes should be safe to merge.

@giauphan

Copy link
Copy Markdown
Owner

Closing due to lockfile mismatch with main. Dependabot will automatically recreate a clean PR against the latest main.

@giauphan giauphan closed this Sep 23, 2026
@dependabot @github

dependabot Bot commented on behalf of github Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/dashboard/multi-7f19880bf6 branch September 23, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant