chore(deps): bump react-dom and @types/react-dom - #317
dependabot[bot] wants to merge 1 commit into
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
giauphan
left a comment
There was a problem hiding this comment.
cc @dependabot[bot] @jules
I've reviewed the diff. The changes bump react-dom and @types/react-dom to v19 while leaving react and @types/react on v18 — that's a breaking version mismatch, since react-dom 19 requires react 19.
Issues:
- File: dashboard/package.json -> Line 22:
react-dombumped to^19.3.0butreactstays at^18.2.0. react-dom 19 requires React 19 (matching majors); this breaks at runtime (hooks/createRooterrors). Bumpreactto^19.3.0together, or keep both on 18. - File: dashboard/package.json -> Line 33:
@types/react-dom^19.3.0with@types/reactstill^18.2.0— the v19 types depend on React 19 types, so type conflicts/errors are guaranteed even before runtime issues. - Minor: no
package-lock.jsonchange in the diff. If the lockfile wasn't regenerated, CI installs will be inconsistent with this manifest — runnpm installand commit the updated lockfile.
Everything else in the diff looks fine.
e36cccb to
192b3f1
Compare
giauphan
left a comment
There was a problem hiding this comment.
cc @dependabot[bot] @jules
I've reviewed the diff — it's just a dependency bump in dashboard/package.json, and it contains a version mismatch that will break the app.
Issues found:
-
File:
dashboard/package.json-> Line 22:react-dombumped to^19.3.0whilereactstays at^18.2.0. React 19 requires React 19 as a peer dependency — this will failnpm install(peer conflict) or break at runtime. Bumpreactto^19.3.0together with it. -
File:
dashboard/package.json-> Line 33:@types/react-dombumped to^19.3.0while@types/reactstays at^18.2.0. The React 19 type packages depend on@types/react@19, so this creates inconsistent typings (and likely a duplicate/conflicting@types/react). Bump@types/reactalongside.
Also worth noting: React 19 is a major upgrade (removed APIs like ReactDOM.render, changes to forwardRef/useRef typing, new JSX transform requirements), so the source should be checked for compatibility after the version alignment — that part isn't visible in this diff.
Otherwise no security, performance, or correctness concerns in the changes shown. Once the React/@types/react versions are aligned, this looks good.
Bumps [react-dom](https://github.com/react/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.3.0 - [Release notes](https://github.com/react/react/releases) - [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/react/react/commits/v19.3.0/packages/react-dom) Updates `@types/react-dom` from 18.3.7 to 19.3.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-version: 19.3.0 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: react-dom dependency-version: 19.3.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
192b3f1 to
e30cf89
Compare
giauphan
left a comment
There was a problem hiding this comment.
cc @dependabot[bot] @jules
I'll review the changes in the GitHub Pull Request diff you provided. Here's my analysis:
Code Changes Review
- Version Bump for React and React-DOM
- File:
dashboard/package.json-> Line 21-22: React and React-DOM versions are being updated from18.2.0to19.3.0 - File:
dashboard/package.json-> Line 32-33: Corresponding type definitions for React-DOM are also being updated from18.2.0to19.3.0
- File:
Analysis
-
Correctness:
- The version bump appears to be intentional and follows semantic versioning principles. No logic bugs or edge cases appear to be introduced by this change alone.
-
Security:
- No security concerns are evident from this change. The version bump is a standard practice for dependency updates.
-
Performance:
- No performance implications are expected from this change. React version updates typically don't introduce performance regressions.
-
Code Quality:
- The change is clean and follows the project's dependency management pattern. No anti-patterns or dead code are introduced.
-
Maintainability:
- The change improves maintainability by updating to the latest stable version of React, which includes bug fixes and potentially new features.
Recommendations
-
Testing:
- Verify that the application works correctly with React 19.3.0 in your development environment.
- Check for any deprecation warnings or breaking changes in the React 19 release notes.
-
Documentation:
- Consider updating any documentation that references specific React versions.
-
Peer Dependencies:
- Ensure all other dependencies in the project are compatible with React 19.3.0.
Everything else looks good. The version bump appears to be a well-intentioned and properly executed change.
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.3.1 to 19.3.0Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
f4e439e[Fizz] Addnonceto renderedimport maps(#37339)21c89c9[DOM] Clean up Fragment listeners on signal abort (#37457)065bc84[DOM] Unobserve fragment IntersectionObserver targets after exit (#37408)ff7445e[DOM] Update HTML parser rules for new select parser (#34804)2dc7da7[test] Bump Jest to 30.4 (#37382)29d9d31[DOM] Copysourceonto the synthetic toggle event (#37389)269bd40[test] Remove the customtoThrowoverride for legacy V8 error messages (#37...a112448[DOM] Treat omitted Fragment Event listener options same ascapture: false...3d05080[Fizz] Construct the render lifetime controller only when it is needed (#37357)77ed3f5[Flight/Fizz] Stop the caller's signal from retaining a finished render (#37315)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react-dom since your current version.
Updates
@types/react-domfrom 18.3.7 to 19.3.0Commits