Skip to content

chore(deps): bump react-dom and @types/react-dom - #317

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/multi-de36fa8f59
Open

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/multi-de36fa8f59

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 14, 2026

Copy link
Copy Markdown
Contributor

Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates react-dom from 18.3.1 to 19.3.0

Release notes

Sourced from react-dom's releases.

19.3.0 (September 9, 2026)

Below is a list of all new features, APIs, and bug fixes.

Read the React 19.3 release post for more information.

New React Features

New React DOM Features

  • browser(): a new react-dom API that returns a usable which errors during server rendering and resolves in the browser. use(browser()) inside a <Suspense> boundary marks a subtree as browser-only without reporting a recoverable error (@​gnoff: #37143, #37241)
    • Added an onBrowserBailout option to the react-dom/server APIs to observe when a subtree defers to the browser (@​gnoff #37193)

Notable changes

All Changes

React

... (truncated)

Changelog

Sourced from react-dom's changelog.

19.3.0 (September 9, 2026)

New React Features

New React DOM Features

  • browser(): a new react-dom API that returns a usable which errors during server rendering and resolves in the browser. use(browser()) inside a <Suspense> boundary marks a subtree as browser-only without reporting a recoverable error (@​gnoff: #37143, #37241)
    • Added an onBrowserBailout option to the react-dom/server APIs to observe when a subtree defers to the browser (@​gnoff #37193)

Notable changes

All Changes

React

... (truncated)

Commits
  • f4e439e [Fizz] Add nonce to rendered import maps (#37339)
  • 21c89c9 [DOM] Clean up Fragment listeners on signal abort (#37457)
  • 065bc84 [DOM] Unobserve fragment IntersectionObserver targets after exit (#37408)
  • ff7445e [DOM] Update HTML parser rules for new select parser (#34804)
  • 2dc7da7 [test] Bump Jest to 30.4 (#37382)
  • 29d9d31 [DOM] Copy source onto the synthetic toggle event (#37389)
  • 269bd40 [test] Remove the custom toThrow override for legacy V8 error messages (#37...
  • a112448 [DOM] Treat omitted Fragment Event listener options same as capture: false ...
  • 3d05080 [Fizz] Construct the render lifetime controller only when it is needed (#37357)
  • 77ed3f5 [Flight/Fizz] Stop the caller's signal from retaining a finished render (#37315)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by GitHub Actions, a new releaser for react-dom since your current version.


Updates @types/react-dom from 18.3.7 to 19.3.0

Commits

@dependabot @github

dependabot Bot commented on behalf of github Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies, npm. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot
dependabot Bot requested a review from giauphan as a code owner September 14, 2026 07:19

@giauphan giauphan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dependabot[bot] @jules

I've reviewed the diff. The changes bump react-dom and @types/react-dom to v19 while leaving react and @types/react on v18 — that's a breaking version mismatch, since react-dom 19 requires react 19.

Issues:

  • File: dashboard/package.json -> Line 22: react-dom bumped to ^19.3.0 but react stays at ^18.2.0. react-dom 19 requires React 19 (matching majors); this breaks at runtime (hooks/createRoot errors). Bump react to ^19.3.0 together, or keep both on 18.
  • File: dashboard/package.json -> Line 33: @types/react-dom ^19.3.0 with @types/react still ^18.2.0 — the v19 types depend on React 19 types, so type conflicts/errors are guaranteed even before runtime issues.
  • Minor: no package-lock.json change in the diff. If the lockfile wasn't regenerated, CI installs will be inconsistent with this manifest — run npm install and commit the updated lockfile.

Everything else in the diff looks fine.

@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/multi-de36fa8f59 branch from e36cccb to 192b3f1 Compare September 22, 2026 11:19

@giauphan giauphan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dependabot[bot] @jules

I've reviewed the diff — it's just a dependency bump in dashboard/package.json, and it contains a version mismatch that will break the app.

Issues found:

  • File: dashboard/package.json -> Line 22: react-dom bumped to ^19.3.0 while react stays at ^18.2.0. React 19 requires React 19 as a peer dependency — this will fail npm install (peer conflict) or break at runtime. Bump react to ^19.3.0 together with it.

  • File: dashboard/package.json -> Line 33: @types/react-dom bumped to ^19.3.0 while @types/react stays at ^18.2.0. The React 19 type packages depend on @types/react@19, so this creates inconsistent typings (and likely a duplicate/conflicting @types/react). Bump @types/react alongside.

Also worth noting: React 19 is a major upgrade (removed APIs like ReactDOM.render, changes to forwardRef/useRef typing, new JSX transform requirements), so the source should be checked for compatibility after the version alignment — that part isn't visible in this diff.

Otherwise no security, performance, or correctness concerns in the changes shown. Once the React/@types/react versions are aligned, this looks good.

Bumps [react-dom](https://github.com/react/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together.

Updates `react-dom` from 18.3.1 to 19.3.0
- [Release notes](https://github.com/react/react/releases)
- [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/react/react/commits/v19.3.0/packages/react-dom)

Updates `@types/react-dom` from 18.3.7 to 19.3.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom)

---
updated-dependencies:
- dependency-name: "@types/react-dom"
  dependency-version: 19.3.0
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: react-dom
  dependency-version: 19.3.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/multi-de36fa8f59 branch from 192b3f1 to e30cf89 Compare September 22, 2026 11:31

@giauphan giauphan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dependabot[bot] @jules

I'll review the changes in the GitHub Pull Request diff you provided. Here's my analysis:

Code Changes Review

  1. Version Bump for React and React-DOM
    • File: dashboard/package.json -> Line 21-22: React and React-DOM versions are being updated from 18.2.0 to 19.3.0
    • File: dashboard/package.json -> Line 32-33: Corresponding type definitions for React-DOM are also being updated from 18.2.0 to 19.3.0

Analysis

  1. Correctness:

    • The version bump appears to be intentional and follows semantic versioning principles. No logic bugs or edge cases appear to be introduced by this change alone.
  2. Security:

    • No security concerns are evident from this change. The version bump is a standard practice for dependency updates.
  3. Performance:

    • No performance implications are expected from this change. React version updates typically don't introduce performance regressions.
  4. Code Quality:

    • The change is clean and follows the project's dependency management pattern. No anti-patterns or dead code are introduced.
  5. Maintainability:

    • The change improves maintainability by updating to the latest stable version of React, which includes bug fixes and potentially new features.

Recommendations

  1. Testing:

    • Verify that the application works correctly with React 19.3.0 in your development environment.
    • Check for any deprecation warnings or breaking changes in the React 19 release notes.
  2. Documentation:

    • Consider updating any documentation that references specific React versions.
  3. Peer Dependencies:

    • Ensure all other dependencies in the project are compatible with React 19.3.0.

Everything else looks good. The version bump appears to be a well-intentioned and properly executed change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant