Optimize gigya script loading#166
Open
mstrelan wants to merge 1 commit intogigya:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the remote gigya.js file is loaded by
Drupal.behaviorsonce the page is loaded. The recommendation for better performance is to load it in<head>with theasyncattribute.There are also a lot of unused dependencies in the library definition that we don't need. From what I can tell:
core/jqueryis only used for thisonLoginHandlerexample that is never usedcore/jquery.onceis never usedcore/drupalis only used forDrupal.behaviorswhich is removed in this PRcore/drupal.ajaxis never used, but AJAX was references in the file comment, which appears to be copy pasta