Skip to content

add support for hasconfig:remote type of directives - #9

Merged
MichaelMure merged 2 commits into
masterfrom
hasconfig
Oct 26, 2026
Merged

MichaelMure merged 2 commits into
masterfrom
hasconfig

Conversation

@MichaelMure

@MichaelMure MichaelMure commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the previous finding is fixed and no new actionable issues were found.

Summary

Adds support for includeIf "hasconfig:remote.*.url:…".

  • Remote URL patterns now decide which conditional include files add settings.
  • Conditional includes now reject remote URLs when a hasconfig section appears.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Read configuration and includes] --> B[Collect remote URLs]
  B --> C{Prohibited remote URL?}
  C -->|Yes| D[Return ErrRemoteURLInInclude]
  C -->|No| E[Match each hasconfig pattern]
  E --> F[Drop entries from unmatched includes]
  F --> G[Return configuration]
Loading

Reviews (6) · Last reviewed commit: "add more fuzzing targets" · Reviewed by Greptile

@MichaelMure
MichaelMure force-pushed the hasconfig branch 2 times, most recently from 276b748 to de3d4b8 Compare October 26, 2026 14:38
Comment thread env_test.go
@MichaelMure
MichaelMure merged commit dadc07f into master Oct 26, 2026
7 checks passed
@MichaelMure
MichaelMure deleted the hasconfig branch October 26, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant