fix: use the learner's own CLI and exercises folder - #26
Merged
Merged
Conversation
Verify was spawning a hard-coded save-folder path, so a self-installed CLI was invisible on Windows while the in-app terminal still found it. Co-authored-by: Cursor <cursoragent@cursor.com>
… them Prepending the save folder to PATH let a stray executable shadow git, and the app was setting up a CLI the lessons already tell learners to install. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The app was installing the CLI into the learner's save folder and putting that folder first on PATH, so a stray executable could shadow
git. It now uses a CLI the learner installed themselves, and asks where they rangitmastery setup.Solution
gitmasteryfrom the normal PATH, plus Homebrew prefixes on macOS. The app no longer downloads or installs the CLI..gitmastery.json, or a parent with exactly one such folder. Setup Instructions in that copy opens T1L2 inside the app. An X forgets the link without deleting files.Test cases
gitmastery setupwas run is accepted; a folder without.gitmastery.jsonis rejected