test: expose membership safety failures under mixed reads - #47
Open
flyingrobots wants to merge 2 commits into
Open
flyingrobots wants to merge 2 commits into
flyingrobots wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 39 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (97)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production safety: FAIL in 21 of 84 synthetic mixed observations. The real release/acquire/claim transactions succeed and leave independent family, capacity or prefix-exclusivity violations. This PR completes the #38 investigation; it does not implement the corrective work tracked by #45, which remains an unresolved release correctness gate in #41.
The controlled reader supplies one planner snapshot assembled from individually valid before/after refs of a completed operation. Objects and transactions use real Git unchanged; retries use real reads. No live Git reader/writer schedule has been reproduced. Backend reachability and publication order remain unverified.
The fixture exhausts the small before/after ref-mix spaces for seeds
38,1701and20260922. Six hand-checked oracle inputs and two discarded-dispatcher-read controls calibrate the experiment. The independent oracle reads raw refs and blobs; it does not reuse production parsers,doctororcheck. The report limits its claims to the studied invariants and transitions.The committed study contains the complete 84-case result ledger, runtime/executable/fixture hashes, representative raw observations, object contents, transaction inputs, final states and control cases.
verify-evidence.pyverifies all 89 receipt paths throughgit ls-filesand checks theirHEADblob hashes. Its observed RED caught ignored.logreceipts in the first commit; a forward commit retains them as.txt, updates the manifest and passes the check.Validation on final head
528b617e3c4c1c7c747756218dd07575661432e2:make test: 452 passed, 0 failed, followed by passing six oracle cases and two discarded-read controls.production_safety: FAIL, 21 violating cases / 84. These failures remain visible; they are not expected-failure assertions converted to passing production tests.A green ordinary suite or calibration verifies that the study additions work and preserve existing tests. It does not establish the affected concurrency guarantee. No production module or generated executable changed. The README now explains why expected ref values alone do not establish coherent membership observation.
Run the study with a fresh output directory:
The current study exits 1; instrumentation/setup errors exit 2. The full method, controls, limitations and retained evidence are in
docs/studies/membership-observation/README.md.Closes #38. Corrective implementation remains open in #45; #20 is a design comparison only.