test: make Unicode locale checks portable - #51
Open
flyingrobots wants to merge 1 commit into
Open
flyingrobots wants to merge 1 commit into
flyingrobots wants to merge 1 commit into
Conversation
Select an installed UTF-8 locale, capture JSON stdout separately from shell diagnostics, and skip only the live integration when no UTF-8 locale exists. RED: supplied Linux review observed 451 passing checks and one schema failure when an en_US.UTF-8 warning was merged with valid JSON. Local failure calibration observed 4 passing fixtures, 1 failing fixture, 1 skipped integration, and an incorrect exit 0. GREEN: live host coverage passed 20 checks under C.UTF-8; the no-locale path passed 5 checks with 1 explicit skip; failure propagation passed 2 calibration checks. Lint and actionlint passed.
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
10 tasks
flyingrobots
marked this pull request as ready for review
September 22, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Unicode integration test hardcoded
en_US.UTF-8and merged stderr into the JSON under test, so a missing-locale warning caused a false schema failure. The test now selects an installed UTF-8 locale, validates claim/list/check stdout separately from diagnostics, and reports an explicit skip when no UTF-8 locale exists. A calibration proves that a skip cannot hide an earlier selector failure.CI now runs the focused test in an Ubuntu 24.04 container containing only
C,C.utf8, andPOSIX. That job reproduces the old merged-stream parse failure with the real CLI, then passes the repaired integration underC.utf8. Product behavior is unchanged.Validation
C.UTF-8: 20 passed, 0 failed, 0 skipped.en_USreproduction and repairedC.utf8integration passed.Fixes #36