Repository navigation
[DB] Use Postgres startup encoding without SET NAMES - #1
Merged
Merged
Conversation
kageiit
force-pushed
the
fix/postgres-startup-encoding
branch
from
October 7, 2026 09:04
9f6f9c3 to
622c886
Compare
poorviparikshya
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres encoding uses the startup packet.
The patched tokio-postgres driver already requests UTF8 when connecting. Quaint repeated it with SET NAMES on every connection, causing all 9,946 RDS Proxy warnings in the production window to report session pinning. Remove the redundant SQL and retain explicit schema initialization.
Validation: local PostgreSQL 17 tests pass for UTF-8 round trips and custom search paths. Formatting passes. All-target clippy completes with the existing approximate-constant test lint allowed, retaining unrelated warnings.
Gitar needs a separate consumer version-pin PR. Existing sessions remain pinned until they reconnect after deployment.
Fork pull requests now run the supported Postgres compatibility workflow, including the encoding and search-path regressions against PostgreSQL 17. The upstream main branch retains its original multi-connector workflow.
Decisions made while unattended