Add Playwright webkit system dependencies#7
Merged
krlvi merged 1 commit intogitbutlerapp:masterfrom Apr 17, 2026
Merged
Conversation
f9932f0 to
5412cf8
Compare
Add apt packages so downstream workflows don't need runtime apt-get: - Playwright webkit deps: libgtk-4-1, libevent-2.1-7, gstreamer1.0-plugins-bad, libflite1, libavif13, libx264-163 - Blackbox e2e deps: webkit2gtk-driver, ffmpeg, xvfb (resolves TODO in test-e2e-blackbox.yml:39) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5412cf8 to
5b36a6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libgtk-4-1,libevent-2.1-7,gstreamer1.0-plugins-bad,libflite1,libavif13,libx264-163) to the base apt layer.webkit2gtk-driver,ffmpeg,xvfb) — resolves the TODO attest-e2e-blackbox.yml:39.Why
Enabling webkit as a Playwright project in
gitbutlerapp/gitbutlersurfaced missing shared libs (libgtk-4.so.1,libevent-2.1.so.7,libgstcodecparsers-1.0.so.0,libflite*,libavif.so.13,libx264.so). The blackbox e2e workflow has beenapt update && apt install-ingwebkit2gtk-driver ffmpeg xvfbat runtime on every run — with a TODO to move them into the image.Test plan
ci-base-imagedigest ingitbutlerapp/gitbutlerand confirm both e2e workflows pass without runtimeapt-get install.🤖 Generated with Claude Code