feat: Add BMP enablement for dataplane CLI#301
Merged
Conversation
sergeymatov
force-pushed
the
pr/smatov/bmp-enablement
branch
from
4a713b0 to
276aa1c
Compare
|
🚀 Temp artifacts published: |
Contributor
|
I arrived here because I was analyzing CI failures and noticed several pointing to this branch: @sergeymatov are you aware the gateway does not become ready? |
Contributor
Author
|
Hello @pau-hedgehog |
Frostman
previously approved these changes
Jan 28, 2026
Member
|
@sergeymatov is bmp support already merged in dataplane? Seems like you change breaks vlab atm |
Contributor
Author
|
@Frostman it is, but there was no version bump afair |
Member
|
@sergeymatov ok, restart jobs then when dp bump is merged into fabricator |
sergeymatov
force-pushed
the
pr/smatov/bmp-enablement
branch
from
276aa1c to
230e03a
Compare
|
🚀 Temp artifacts published: |
sergeymatov
force-pushed
the
pr/smatov/bmp-enablement
branch
from
230e03a to
9edc7d9
Compare
|
🚀 Temp artifacts published: |
sergeymatov
force-pushed
the
pr/smatov/bmp-enablement
branch
from
9edc7d9 to
7969090
Compare
|
🚀 Temp artifacts published: |
The BMP listener port is hardcoded for now, later we will make it available via `GatewayConfig` Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
Frostman
force-pushed
the
pr/smatov/bmp-enablement
branch
from
7969090 to
631284e
Compare
Frostman
approved these changes
Feb 4, 2026
|
🚀 Temp artifacts published: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BMP listener port is hardcoded for now, later
we will make it available via
GatewayConfig@Frostman we are having hardcoded values cause it's purely for internal usage. But if we need to make it configurable please let me know