Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces multi-VPC support to the host-based BGP routing configuration script. VIPs and interfaces are now associated with VPC identifiers, and BGP prefixes are filtered per VPC using route-maps. The PR also adds VLAN support with automatic interface creation.
Changes:
- Rewrote argument parsing to support VPC-based configuration format with VLAN, interface, and address specifications
- Added VLAN interface creation logic with automatic naming (interface.vlan)
- Implemented route-map and prefix-list generation for per-VPC BGP filtering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edipascale
force-pushed
the
ema/multi-vpcs
branch
from
f3a1834 to
06b5537
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VIPs and interfaces are now associated with a VPC, which is just a string identifier. prefixes are only advertised to neighbors within one VPC, filtering is done via route-maps. vlan support was also added, vlan interface will automatically be created. Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
edipascale
force-pushed
the
ema/multi-vpcs
branch
from
06b5537 to
e3cc9b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIPs and interfaces are now associated with a VPC, which is just a string identifier. prefixes are only advertised to neighbors within one VPC, filtering is done via route-maps.
vlan support was also added, vlan interface will automatically be created.