Skip to content

[GHSA-g3hv-75wg-m249] minimatch has potential denial of service via globparts amplification - #10810

Open
JTW17 wants to merge 1 commit into
JTW17/advisory-improvement-10810from
JTW17-GHSA-g3hv-75wg-m249
Open

JTW17 wants to merge 1 commit into
JTW17/advisory-improvement-10810from
JTW17-GHSA-g3hv-75wg-m249

Conversation

@JTW17

@JTW17 JTW17 commented Oct 31, 2026

Copy link
Copy Markdown

Updates

  • Affected products

Comments
The affected range starts too early. The vulnerable code described in this advisory — firstPhasePreProcess(), the /../ globParts cloning (const other = parts.slice(0); other[gs] = ''; globParts.push(other)) and the pairwise partsMatch loop in secondPhasePreProcess() — was introduced in minimatch 7.0.0. It is not present in any 3.x–6.x release.

Verified on 2026-10-31 against the published npm tarballs:

  • 3.1.5, 4.2.6, 5.1.9, 6.2.3: no occurrence of firstPhasePreProcess, secondPhasePreProcess, optimizationLevel, globParts.push, other[gs] or partsMatch.
  • 7.0.0: firstPhasePreProcess, globParts.push, other[gs] and partsMatch present (optimizationLevel added in 7.1.0).
  • 7.4.9, 10.2.6: all of the above present.

Suggested range: >= 7.0.0, < 11.0.1. This removes false positives for the widely used legacy 3.x line (e.g. eslint 9 and its plugins), which cannot move to 11.x because it relies on the callable default export.

@github

github commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator

Hi there @isaacs! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions
github-actions Bot changed the base branch from main to JTW17/advisory-improvement-10810 October 31, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants