feat(skills): add clean-architecture skill#1522
Open
lfr-ai wants to merge 2 commits intogithub:stagedfrom
Open
feat(skills): add clean-architecture skill#1522lfr-ai wants to merge 2 commits intogithub:stagedfrom
lfr-ai wants to merge 2 commits intogithub:stagedfrom
Conversation
Single self-contained SKILL.md enforcing Clean Architecture boundaries, the Dependency Rule, and layered separation of concerns across any language or framework. Covers: 4-layer model, review checklist, domain purity red flags, anti-patterns, key patterns (Repository, Use Case, Composition Root), and severity guide.
Contributor
🔍 Skill Validator Results
Summary
Full validator output```text Found 1 skill(s) [clean-architecture] 📊 clean-architecture: 1,207 BPE tokens [chars/4: 1,394] (detailed ✓), 19 sections, 3 code blocks [clean-architecture] ⚠ No numbered workflow steps — agents follow sequenced procedures more reliably. ✅ All checks passed (1 skill(s)) ``` |
utkarsh232005
approved these changes
Apr 27, 2026
aaronpowell
reviewed
Apr 28, 2026
Contributor
aaronpowell
left a comment
There was a problem hiding this comment.
This reads more like an instruction rather than a skill and it is very light on in terms of what guidance it is giving to the agent. Because of the complexity of clean architecture, I would expect any agent guidance to be detailed on how to implement the various boundaries, how to do command layers, etc.
Author
|
@aaronpowell Would you then recommend me to rewrite it into a more exhaustive setup along the lines of: https://github.com/github/awesome-copilot/tree/main/skills/security-review? |
Contributor
|
Yes, a skill like that is a good pattern on handling a complex topic and providing the skill with deep knowledge and decision making processes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single self-contained SKILL.md enforcing Clean Architecture boundaries, the Dependency Rule, and layered separation of concerns across any language or framework.
Covers: 4-layer model, review checklist, domain purity red flags, anti-patterns, key patterns (Repository, Use Case, Composition Root), and severity guide.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.stagedbranch for this pull request.Description
Added clean-architecture skills for writing clean-architecture with Github-Copilot.
Type of Contribution
Additional Notes
N/A
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.