[external-plugin] Update sumo-logic plugin keywords - #3217
vsinghal13 wants to merge 3 commits into
Conversation
🔒 PR Risk Scan ResultsScanned 2 changed file(s).
✅ No matching risk patterns were detected in changed files.
|
✅ External plugin PR checks passed
Per-plugin quality summary
Gate output detailssumo-logic - spec compliance (✅ pass)sumo-logic - vally lint (✅ pass)sumo-logic - install smoke test (✅ pass)sumo-logic - version match (pass)sumo-logic - ref/sha consistency (pass)sumo-logic - canvas structure (not_run) |
There was a problem hiding this comment.
🟡 Changes recommended
The new keywords and regenerated marketplace output are missing.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the pinned Sumo Logic plugin revision to target its latest metadata.
Changes:
- Replaces the pinned commit SHA for
sumo-logic.
File summaries
| File | Description |
|---|---|
plugins/external.json |
Updates the Sumo Logic plugin source SHA. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aaronpowell
left a comment
There was a problem hiding this comment.
A SHA change requires the version bumped for a plugin, I would also expect that the ref has changed as the ref should be treated as immutable (yes, you can force push to a tag so it's not truly immutable).
Also, the marketplace.json needs to be regenerated with the changes.
There was a problem hiding this comment.
🟡 Changes recommended
The committed source ref and SHA conflict with the artifact identified in the PR description.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
…etplace - Version: 1.0.0 → 1.0.1 - Ref: v1.0.0 → v1.0.1 - SHA: updated to match v1.0.1 tag - Keywords: added devops, search, security (removed siem) - Regenerated marketplace.json Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fc745d8 to
f588b3a
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The source ref and SHA contradict the exact values stated in the PR description.
Review details
Suppressed comments (1)
plugins/external.json:1278
- The immutable source locator contradicts the PR description, which says the ref remains
v1.0.0and the new SHA is607c742cfb18ca8a9b150b3c93589dad1a842345; this entry instead selectsv1.0.1atf905b914984fabb5e0571290eafd3013c277d9b1. Since these fields determine the exact plugin code users install, align the entry with the reviewed source or update the PR description and verify the new tag/SHA provenance before merging.
"ref": "v1.0.1",
"sha": "f905b914984fabb5e0571290eafd3013c277d9b1"
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Summary
sumo-logicplugin version to1.0.1with new tagv1.0.1devops,search,securitymarketplace.jsonDetails
1.0.0→1.0.1v1.0.0→v1.0.1f905b914984fabb5e0571290eafd3013c277d9b1