Skip to content

Upgrade github/codeql dependency to 2.23.9 - #1179

Open
github-actions[bot] wants to merge 119 commits into
mainfrom
codeql/upgrade-to-2.23.9
Open

github-actions[bot] wants to merge 119 commits into
mainfrom
codeql/upgrade-to-2.23.9

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown

This PR upgrades the CodeQL CLI version to 2.23.9.

CodeQL dependency upgrade checklist:

  • Confirm the code has been correctly reformatted according to the new CodeQL CLI.
  • Identify any CodeQL compiler warnings and errors, and update queries as required.
  • Validate that the github/codeql test cases succeed.
  • Address any CodeQL test failures in the github/codeql-coding-standards repository.
  • Validate performance vs pre-upgrade, using /test-performance

jketema and others added 30 commits March 6, 2025 13:52
Update expected test results after frontend update
Update MISRA queries and tests after merging location tables
C++: accept new test results after QL changes
Observe that `sizeof(...)` might not occur as a dataflow node if it has a
parent node with a concrete value. That value will be a dataflow node instead.
Hence, the query has be changed to check for expressions where `sizeof(...)`
is a child of an expression with a concrete value.
Note that we now properly report the offending cast instead of the expression
that is being cast.
As it is the dataflow used by `asctime` that is relevant, and not the pointer,
use the indirect expression.
Convert a number of queries to use the new dataflow library
Update expected test results for MSC33-C
Since the new dataflow library uses use-use dataflow and not def-use dataflow,
we now need to check for definitions. Note that these queries can probably be
improved by using a dataflow configuration - possibly limited to the local
context of a function by including `DataFlow::FeatureEqualSourceSinkCallContext`
@MichaelRFairhurst

Copy link
Copy Markdown
Collaborator

/test-performance

@github-actions

Copy link
Copy Markdown
Author

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@MichaelRFairhurst

Copy link
Copy Markdown
Collaborator

/test-performance

@github-actions

Copy link
Copy Markdown
Author

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@mbaluda
mbaluda changed the base branch from main to mbaluda/exp37-c August 28, 2026 09:18
@mbaluda
mbaluda changed the base branch from mbaluda/exp37-c to main August 28, 2026 09:18
@MichaelRFairhurst

Copy link
Copy Markdown
Collaborator

/test-performance

@github-actions

Copy link
Copy Markdown
Author

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@MichaelRFairhurst

Copy link
Copy Markdown
Collaborator

/test-performance

@github-actions

Copy link
Copy Markdown
Author

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@codeql-coding-standards-automation

Copy link
Copy Markdown

🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo.


Release                            : v2.61.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4615626
Mean_Predicate_Execution_Time_Ms   : 64.84988900441172
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 574.4148904892992
Total_Serialized_Execution_Time_s  : 4615.626
Mean_Query_Execution_Time_s        : 0.0648498890044117
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 165.0
Number_of_Predicates               : 71174

Release                            : v2.61.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 3266370
Mean_Predicate_Execution_Time_Ms   : 63.90362718628947
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 503.1579843913974
Total_Serialized_Execution_Time_s  : 3266.37
Mean_Query_Execution_Time_s        : 0.0639036271862894
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 191.0
Number_of_Predicates               : 51114

Release                            : v2.61.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4756186
Mean_Predicate_Execution_Time_Ms   : 66.62911337433282
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 451.0173047967091
Total_Serialized_Execution_Time_s  : 4756.186
Mean_Query_Execution_Time_s        : 0.0666291133743328
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 208.0
Number_of_Predicates               : 71383

Release                            : v2.61.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2784651
Mean_Predicate_Execution_Time_Ms   : 54.388777124553215
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 610.0917903271135
Total_Serialized_Execution_Time_s  : 2784.651
Mean_Query_Execution_Time_s        : 0.0543887771245532
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 142.0
Number_of_Predicates               : 51199

Release                            : v2.62.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2655267
Mean_Predicate_Execution_Time_Ms   : 51.8738546896673
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 558.1246726024739
Total_Serialized_Execution_Time_s  : 2655.267
Mean_Query_Execution_Time_s        : 0.0518738546896673
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 138.0
Number_of_Predicates               : 51187

Release                            : v2.62.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4355006
Mean_Predicate_Execution_Time_Ms   : 61.04492507814581
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 537.0863746976181
Total_Serialized_Execution_Time_s  : 4355.006
Mean_Query_Execution_Time_s        : 0.0610449250781458
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 165.0
Number_of_Predicates               : 71341

Release                            : v2.62.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4958885
Mean_Predicate_Execution_Time_Ms   : 69.36085545640194
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 468.2069608070895
Total_Serialized_Execution_Time_s  : 4958.885
Mean_Query_Execution_Time_s        : 0.0693608554564019
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 218.0
Number_of_Predicates               : 71494

Release                            : v2.62.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 3809287
Mean_Predicate_Execution_Time_Ms   : 74.47432012356057
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 607.469703694893
Total_Serialized_Execution_Time_s  : 3809.287
Mean_Query_Execution_Time_s        : 0.0744743201235605
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 196.0
Number_of_Predicates               : 51149

Release                            : 1179
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2271495
Mean_Predicate_Execution_Time_Ms   : 41.49986297615785
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 449.4208441795379
Total_Serialized_Execution_Time_s  : 2271.495
Mean_Query_Execution_Time_s        : 0.0414998629761578
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 115.0
Number_of_Predicates               : 54735

Release                            : 1179
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 3993146
Mean_Predicate_Execution_Time_Ms   : 52.38974022566256
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 446.745543849436
Total_Serialized_Execution_Time_s  : 3993.146
Mean_Query_Execution_Time_s        : 0.0523897402256625
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 148.0
Number_of_Predicates               : 76220

🏁 Below are the slowest predicates for the last 2 releases vs this PR.


Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : FunctionEquivalence::typeSig/1#194ac728
Execution_Time_Ms : 24488

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 18257

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 35486

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _Class::Class.getALinkTarget/0#dispred#29b2b38a#bf_Class::Class.getALinkTarget/0#dispred#29b2b38a#bf__#shared
Execution_Time_Ms : 25854

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : misra-default
Predicate         : IncompatibleFunctionDeclaration::interestedInFunctions/4#95575433
Execution_Time_Ms : 23074

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 36107

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 32647

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 31549

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 25356

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 40850

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 35596

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : Dependency::dependsOnTransitive/2#cbda84a0
Execution_Time_Ms : 26611

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : cert-default
Predicate         : IncompatibleFunctionDeclaration::interestedInFunctions/4#95575433
Execution_Time_Ms : 26535

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Class::Class.getALinkTarget/0#dispred#29b2b38a#bf_Class::Class.getALinkTarget/0#dispred#29b2b38a#bf__#shared
Execution_Time_Ms : 28287

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CharacterOutsideTheLanguageStandardBasicSourceCharacterSetUsedInTheSourceCode::getUniversalCharacterName/1#36dbaa42
Execution_Time_Ms : 33680

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 29311

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : VirtualDispatchPrototype::VirtualDispatch::cannotInheritHelper/4#7c75bd87
Execution_Time_Ms : 27766

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CheckedException::CheckedException#b0aa5ec8
Execution_Time_Ms : 27027

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 31340

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 39979

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 20099

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 31086

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : HoldsForAllCopies::HoldsForAllCopies<DeadCode::DeadOperationInstance,Expr::Expr>::RelevantElement#acaf8a9e
Execution_Time_Ms : 37953

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : AlertReporting::MacroUnwrapper<Expr::Expr>::getAMacroInvocation/1#942dfbb7
Execution_Time_Ms : 26606

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : cpp
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 19764

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 31371

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : #select
Execution_Time_Ms : 20537

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : cpp
Suite             : misra-default
Predicate         : AlertReporting::MacroUnwrapper<Expr::Expr>::getAMacroInvocation/1#942dfbb7
Execution_Time_Ms : 28644

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CharacterOutsideTheLanguageStandardBasicSourceCharacterSetUsedInTheSourceCode::getUniversalCharacterName/1#36dbaa42
Execution_Time_Ms : 24758

Release           : 1179
Run               : 2026-09-16_20-40-46
Platform          : x86-linux
Language          : cpp
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#0b6a13dd#cpe#1236
Execution_Time_Ms : 24860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants