Add React missing useRef related constructs#20668
Merged
asgerf merged 6 commits intogithub:mainfrom Dec 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for React's useRef hook by introducing a PreCallGraphStep for data flow tracking and a DomValueSource for DOM value detection. This enhancement improves taint tracking through useRef patterns.
- Added
UseRefStepto model data flow from initial value throughuseRefto.currentproperty access - Added
UseRefDomValueSourceto identify DOM values accessed viauseRef().current
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| javascript/ql/lib/semmle/javascript/frameworks/React.qll | Implements UseRefStep for data flow tracking and UseRefDomValueSource for DOM value detection |
| javascript/ql/lib/change-notes/2025-10-21-react-precallgraph-step.md | Documents the new features in the change notes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
asgerf
reviewed
Oct 23, 2025
Contributor
|
Waiting for another DCA run |
Co-authored-by: Asger F <asgerf@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
7230814 to
7b8a3d0
Compare
asgerf
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the following:
PreCallGraphStepis similar to theuseStatehook related one, but for the hookuseRef.DomValueSourcethat uses thereffrom a dom. This may effect sources found for this query, and therefore the alerts found for that query.