Java: revert revert of paths / paths-ignore handling in XML and other ancillary extractor
#21137
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous revert to restore functionality where the Java extractor respects paths and paths-ignore settings from code-scanning configurations when searching for XML and properties files.
- Adds a change note documenting the restored behavior for XML and properties file handling
- Includes a comprehensive integration test to verify path filtering works correctly
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| java/ql/lib/change-notes/2025-12-16-java-xml-paths.md | Documents that XML and properties files now respect paths/paths-ignore settings |
| java/ql/integration-tests/java/buildless-paths/test.ql | Query to test both Java files and XML files are correctly filtered |
| java/ql/integration-tests/java/buildless-paths/test.py | Test harness that creates database with code-scanning config |
| java/ql/integration-tests/java/buildless-paths/test.expected | Expected output showing only included files appear |
| java/ql/integration-tests/java/buildless-paths/codescanning-config.yml | Configuration defining paths to include and exclude |
| java/ql/integration-tests/java/buildless-paths/sibling/ShouldNotAppear1.{java,xml} | Test files outside included paths that should be filtered out |
| java/ql/integration-tests/java/buildless-paths/include/ShouldAppear2.{java,xml} | Test files in included path that should appear in results |
| java/ql/integration-tests/java/buildless-paths/include/exclude/ShouldNotAppear3.{java,xml} | Test files in explicitly excluded path that should be filtered out |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
henrymercer
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.