Skip to content

Canvas SDK E2E tests across all 5 languages #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmoseley wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Canvas SDK E2E tests across all 5 languages #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efd313a
Add canvas E2E tests across all 5 SDKs
jmoseley May 25, 2026
0e5b237
Add TODO comment explaining ToRpcException code prefix
jmoseley May 25, 2026
3df561a
Dispose canvas E2E sessions and fix .NET nullable warning
jmoseley May 26, 2026
3bd1018
Merge branch 'main' into jmoseley/canvas-e2e-tests-all-sdks
jmoseley May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dotnet/src/Canvas.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ public static LocalRpcInvocationException HandlerError(string message) => Build(
"canvas_handler_error",
message);

public static LocalRpcInvocationException ToRpcException(CanvasError error) => Build(error.Code, error.Message);
// Code is prefixed into the message because RemoteRpcException does not currently
// surface the JSON-RPC error.data payload to callers, so the structured code (e.g.
// "canvas_action_no_handler") would otherwise be unobservable on the receiving side.
// TODO: plumb error.data through RemoteRpcException and drop the prefix here.
public static LocalRpcInvocationException ToRpcException(CanvasError error) => Build(error.Code, $"{error.Code}: {error.Message}");

private static LocalRpcInvocationException Build(string code, string message)
{
Expand Down
345 changes: 143 additions & 202 deletions dotnet/test/E2E/CanvasE2ETests.cs
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading