Mirror Node SDK releases to internal feed#2025
Open
MackinnonBuck wants to merge 4 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b6e76edd-7acc-4681-a884-56d16967c048
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b6e76edd-7acc-4681-a884-56d16967c048
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b6e76edd-7acc-4681-a884-56d16967c048
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b6e76edd-7acc-4681-a884-56d16967c048
Contributor
SDK Consistency Review✅ No cross-SDK API consistency issues found. This PR modifies CI/CD publish infrastructure (
No SDK client API changes were introduced, so there are no cross-language consistency gaps. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds reliable Node SDK mirroring from public npm to the internal Azure Artifacts feed.
Changes:
- Adds fail-closed npm preflight and conflict classification.
- Packages once and reuses the immutable artifact for both registries.
- Adds Azure OIDC-based internal publishing and focused tests.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Splits packaging/public/internal publishing and scopes permissions. |
nodejs/scripts/npm-release.js |
Implements preflight and retry conflict handling. |
nodejs/test/npm-release.test.ts |
Tests preflight and conflict classification. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Medium
| if (result.status === 0) return; | ||
|
|
||
| const output = `${result.stdout}\n${result.stderr}`; | ||
| if (PUBLIC_CONFLICT.test(output) || (mode === "azure" && AZURE_CONFLICT.test(output))) { |
devm33
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Stable, prerelease, and unstable Node SDK releases should mirror to the internal Azure Artifacts feed after authoritative publication to public npm.
What
@github/copilot-sdkversion is definitively absent from public npm.copilot-canaryfeed.Retry semantics
Fresh or full reruns fail before packaging when the selected version already exists. Rerunning failed jobs skips successful prerequisite jobs, reuses their immutable tarball artifact, and treats only known immutable-version conflicts as successful retries.
Validation
actionlint .github/workflows/publish.ymlgit diff --check