Open
Conversation
- Updated nodejs and test harness dependencies - Re-ran code generators - Formatted generated code
Contributor
There was a problem hiding this comment.
Pull request overview
Automated dependency bump of @github/copilot to 1.0.7 across the Node packages, followed by regenerating the cross-language (Node/Python/Go/.NET) RPC and session-event bindings to match the updated schema.
Changes:
- Updated
@github/copilotdependency versions in Node package manifests/locks (main package, samples, test harness). - Regenerated RPC client types/APIs and session event models across Node, Python, Go, and .NET.
- Added newly surfaced schema fields/events/APIs (e.g.,
urlfields on log/events; skills/MCP/plugins/extensions APIs; new session events).
Reviewed changes
Copilot reviewed 4 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/harness/package.json | Bumps @github/copilot devDependency to ^1.0.7. |
| test/harness/package-lock.json | Lockfile update for @github/copilot@1.0.7 and platform optional deps. |
| nodejs/package.json | Bumps @github/copilot dependency to ^1.0.7. |
| nodejs/package-lock.json | Lockfile update for @github/copilot@1.0.7 and platform optional deps. |
| nodejs/samples/package-lock.json | Samples lockfile updated to @github/copilot@^1.0.7. |
| nodejs/src/generated/session-events.ts | Regenerated TS session-event types (new fields/events, some type shape changes). |
| nodejs/src/generated/rpc.ts | Regenerated TS RPC types; adds skills/MCP/plugins/extensions RPC surfaces. |
| python/copilot/generated/session_events.py | Regenerated Python session-event models (new types/events/fields). |
| python/copilot/generated/rpc.py | Regenerated Python RPC bindings; adds skills/MCP/plugins/extensions APIs and agent reload. |
| go/rpc/generated_rpc.go | Regenerated Go RPC bindings; adds new APIs and types (currently has naming/typing issues). |
| go/generated_session_events.go | Regenerated Go session-event models (new events/fields/types; currently has enum constant naming issues). |
| dotnet/src/Generated/SessionEvents.cs | Regenerated .NET session-event types (new events/fields; some public API type changes). |
| dotnet/src/Generated/Rpc.cs | Regenerated .NET RPC bindings; adds new APIs and adds url to session.log (signature change). |
Files not reviewed (3)
- nodejs/package-lock.json: Language not supported
- nodejs/samples/package-lock.json: Language not supported
- test/harness/package-lock.json: Language not supported
Comments suppressed due to low confidence (3)
go/rpc/generated_rpc.go:541
- The generated
ExtensionStatusconstants use non-deterministic prefixes (FluffyDisabled/FluffyFailed). These exported names are hard to understand and will vary across regenerations if collisions change. Consider updating the generator to emit stable, type-prefixed names (e.g.,ExtensionStatusDisabled,ExtensionStatusFailed).
// Current status: running, disabled, failed, or starting
type ExtensionStatus string
const (
FluffyDisabled ExtensionStatus = "disabled"
FluffyFailed ExtensionStatus = "failed"
Running ExtensionStatus = "running"
Starting ExtensionStatus = "starting"
)
go/generated_session_events.go:1295
- The generated
ExtensionStatusenum values are exposed as exported Go identifiers with non-deterministic prefixes (PurpleDisabled,PurpleFailed). This makes the public API confusing and brittle. Prefer stable, type-prefixed constant names (e.g.,ExtensionStatusDisabled,ExtensionStatusFailed) to avoid collisions without random words.
// Current status: running, disabled, failed, or starting
type ExtensionStatus string
const (
PurpleDisabled ExtensionStatus = "disabled"
PurpleFailed ExtensionStatus = "failed"
Running ExtensionStatus = "running"
Starting ExtensionStatus = "starting"
)
go/generated_session_events.go:1303
- The generated
KindStatusconstants includeFluffyFailed, which looks like an accidental/random prefix added for collision avoidance. For a public Go SDK, these should be stable and self-describing (e.g.,KindStatusFailed) rather than using arbitrary words.
// Whether the agent completed successfully or failed
type KindStatus string
const (
Completed KindStatus = "completed"
FluffyFailed KindStatus = "failed"
)
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+1394
to
+1398
| Connected ServerStatus = "connected" | ||
| FluffyDisabled ServerStatus = "disabled" | ||
| NotConfigured ServerStatus = "not_configured" | ||
| Pending ServerStatus = "pending" | ||
| TentacledFailed ServerStatus = "failed" |
Comment on lines
1259
to
1263
| /// <summary>Calls "session.log".</summary> | ||
| public async Task<SessionLogResult> LogAsync(string message, SessionLogRequestLevel? level = null, bool? ephemeral = null, CancellationToken cancellationToken = default) | ||
| public async Task<SessionLogResult> LogAsync(string message, SessionLogRequestLevel? level = null, bool? ephemeral = null, string? url = null, CancellationToken cancellationToken = default) | ||
| { | ||
| var request = new SessionLogRequest { SessionId = _sessionId, Message = message, Level = level, Ephemeral = ephemeral }; | ||
| var request = new SessionLogRequest { SessionId = _sessionId, Message = message, Level = level, Ephemeral = ephemeral, Url = url }; | ||
| return await CopilotClient.InvokeRpcAsync<SessionLogResult>(_rpc, "session.log", [request], cancellationToken); |
Comment on lines
+1441
to
+1444
| /// <summary>Origin of this message, used for timeline filtering (e.g., "skill-pdf" for skill-injected messages that should be hidden from the user).</summary> | ||
| [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] | ||
| [JsonPropertyName("source")] | ||
| public UserMessageDataSource? Source { get; set; } | ||
| public string? Source { get; set; } |
Comment on lines
+980
to
+987
| func (a *McpRpcApi) List(ctx context.Context) (*SessionMcpListResult, error) { | ||
| req := map[string]interface{}{"sessionId": a.sessionID} | ||
| raw, err := a.client.Request("session.mcp.list", req) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| var result SessionMcpListResult | ||
| if err := json.Unmarshal(raw, &result); err != nil { |
Comment on lines
+514
to
+523
| // Connection status: connected, failed, pending, disabled, or not_configured | ||
| type ServerStatus string | ||
|
|
||
| const ( | ||
| Connected ServerStatus = "connected" | ||
| NotConfigured ServerStatus = "not_configured" | ||
| Pending ServerStatus = "pending" | ||
| PurpleDisabled ServerStatus = "disabled" | ||
| PurpleFailed ServerStatus = "failed" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated update of
@github/copilotto version1.0.7.Changes
@github/copilotinnodejs/package.jsonandtest/harness/package.jsonscripts/codegen)