Repository navigation
Conversation
bayandin
force-pushed
the
fix-preserve-historical-sha-pins
branch
2 times, most recently
from
October 14, 2026 09:09
f0a8ff8 to
95a7e88
Compare
bayandin
changed the title
bayandin
force-pushed
the
fix-preserve-historical-sha-pins
branch
from
October 14, 2026 10:44
deb144a to
19daa8c
Compare
bayandin
changed the title
Only replace a bare SHA with a branch name when its head matches the pinned commit. Keep containing branches as metadata for older commits, both during reverse lookup and when repairing existing lockfile entries.
Update the existing branch-repair test fixture to provide the branch head. Cover distinct historical commits on the same branch in fresh and existing lockfiles, including adding a workflow to existing inventory. Check that branch heads and exact tags still normalize to symbolic refs.
bayandin
force-pushed
the
fix-preserve-historical-sha-pins
branch
from
October 14, 2026 10:48
19daa8c to
8489db0
Compare
bayandin
marked this pull request as ready for review
October 14, 2026 10:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Different historical SHA refs can belong to the same branch. Reverse lookup replaces each SHA with that branch name even after its head has advanced, causing planning to fail with
conflicting planned target owner/action@main resolves to both .... Repairing existing lockfile entries can cause the same collision.Fix
Only rewrite a bare SHA to a branch name when the branch head matches the pinned commit, both during initial reverse lookup and existing-lockfile repair. Keep the containing branch as metadata for historical pins. Exact tags continue to identify their matching commits.
Regression tests cover fresh and existing lockfiles, adding a workflow to existing inventory, historical commits, exact branch heads, and exact tags.
Validation
make test, including release fixtures andgo test -race -count=1 ./....make vet,make fmt-check, andgit diff --check.make test-stub: all 34 compiled-binary integration scenarios.