Enable host-gateway setup for explicit Ollama host domains - #8172
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Explicit host domains incorrectly trigger localhost-to-host gateway remapping.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Extends host-gateway detection for Ollama configurations using host.docker.internal.
Changes:
- Recognizes explicit host-domain variants.
- Preserves explicit entries and custom ports.
- Adds focused parser coverage.
File summaries
| File | Description |
|---|---|
src/parsers/dns-parsers.ts |
Extends host-gateway keyword processing. |
src/parsers/dns-parsers.test.ts |
Tests explicit Ollama host configuration. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| d === 'host.docker.internal' || | ||
| d === 'http://host.docker.internal' || | ||
| d === 'https://host.docker.internal' |
|
@copilot rebase onto main and address review feedback |
…sconfiguration Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
|
✅ Copilot review passed with no inline comments. @copilot Add the |
|
@copilot fix the failing ci check https://github.com/github/gh-aw-firewall/actions/runs/33979824141/job/101344113836?pr=8172 |
Fixed in 9a63be8. The failing type-check fixture now includes |
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓
|
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
✅ Contribution Check completed successfully! PR #8172 follows the listed contribution guidelines: it includes focused tests for the new host-gateway behavior, keeps files in the correct src/ layout, and the PR description references the related issue. No comment needed.
|
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅
|
|
🔌 Smoke Services — All services reachable! ✅
|
|
📰 DEVELOPING STORY: Smoke Docker Sbx reports failed. Our correspondents are investigating the incident...
|
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤
|
|
❌ Smoke Claude failed Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "api.anthropic.com"See Network Configuration for more information.
|
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation...
|
|
❌ Smoke Gemini reports failed. Facets need polishing...
|
|
✅ Build Test Suite completed successfully!
|
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓 Smoke test failed: GitHub MCP live result mismatch; review required
|
|
🚀 Security Guard has started processing this pull request |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.
|
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (github.com) reachable: Overall: PASS cc Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Smoke Test: Copilot BYOK (Direct) Mode ✅Status: PASS All tests passed. Running in direct BYOK mode (
|
|
Smoke Test: Copilot Engine — Overall: PASS
Recent merged PRs: #8171 "Shrink Squid negative DNS TTL to stop caching transient SERVFAILs", #8166 "Upgrade gh-aw to latest pre-release" cc
|
|
Smoke test results:
Overall: FAIL —
|
Chroot Version Comparison
Overall: FAILED — Node.js version mismatch between host and chroot environments.
|
|
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Notes:
|
Smoke Test: API Proxy OTel Tracing — Results
Overall: All 5 scenarios pass. Graceful degradation confirmed (no errors when OTEL not fully exercised); tracing infrastructure is functioning correctly end-to-end for available signals.
|
|
Enable host-gateway setup for explicit Ollama host domains
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra cc
|
Ollama workflows targeting
host.docker.internalwere allowlisted but did not trigger AWF’s host-gateway setup, preventing sandboxed agents from reaching the host Ollama service.host.docker.internalhttp://host.docker.internalhttps://host.docker.internal{ "network": { "allowDomains": ["host.docker.internal"] }, "security": { "allowHostPorts": ["11434"] } }