[log] Add debug logging to tool_registry_helpers.go#9605
Merged
Conversation
Add meaningful debug logging calls to internal/server/tool_registry_helpers.go using the existing logToolRegistryHelpers logger (server:tool_registry_helpers namespace): - registerToolWithoutValidation: log tool name when registering - fetchBackendList: log serverID and method on entry, and error responses - registrationErrors.finish: log success summary when all backends registered These logs help diagnose tool registration issues and backend connectivity problems during development and production troubleshooting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds targeted debug logging for tool registration and backend list operations.
Changes:
- Logs tool registration and backend list requests/errors.
- Logs successful completion across all backends.
Show a summary per file
| File | Description |
|---|---|
internal/server/tool_registry_helpers.go |
Adds lifecycle and error-response debug logs. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds meaningful debug logging calls to
internal/server/tool_registry_helpers.gousing the existinglogToolRegistryHelperslogger (server:tool_registry_helpersnamespace).Changes
registerToolWithoutValidation: log tool name when registering with the SDK serverfetchBackendList: logserverIDandmethodon entry; log error response details (code) when backend returns an errorregistrationErrors.finish: log a success summary when all backends registered successfully (complements the existing error path log)Why
These log points cover the key lifecycle events for tool registration and backend list fetching, making it easier to trace registration issues and backend connectivity problems when
DEBUG=server:*is enabled.Validation
go test ./internal/server/— all tests passgo vet ./internal/server/— no issuesgo build— compiles successfullyWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpgSee Network Configuration for more information.