Skip to content

[code-simplifier] simplify: extract update_branch via destructuring in update_pull_request.cjs #27281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Draft

[code-simplifier] simplify: extract update_branch via destructuring in update_pull_request.cjs #27281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions actions/setup/js/update_pull_request.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,9 @@ async function executePRUpdate(github, context, prNumber, updateData) {
const rawBody = updateData._rawBody;
const includeFooter = updateData._includeFooter !== false; // Default to true

// Remove internal fields
const { _operation, _rawBody, _includeFooter, _workflowRepo, ...apiData } = updateData;
const updateBranch = apiData.update_branch === true;
delete apiData.update_branch;
// Remove internal fields (including update_branch which is handled separately below)
const { _operation, _rawBody, _includeFooter, _workflowRepo, update_branch, ...apiData } = updateData;
const updateBranch = update_branch === true;

if (updateBranch) {
core.info(`Updating pull request #${prNumber} branch with base branch changes`);
Expand Down