Enforce gh-aw v0.85.3 security compatibility floor#55796
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot can you ban the range of releases flagged by the advisory? |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed in |
|
@copilot v0.85.4 it's the first valid version that doesn't contain such a misreading of the advisory—or is the advisory… |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Corrected in |
|
@copilot update the skill to make sure to run a schema validator on compat.json (there should be a task in main), also maintain a compat.md that lists why these versions are blocked linking to the advisories |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed in |
|
@copilot ensure that there is a unit test that validate that compat.json is valid w.r.t to the compat schema. |
|
@copilot the skill should tell the agent to provide remediation instructions, similarly to the advisory (see updated content in https://github.com/github/gh-aw/security/advisories/GHSA-8h78-hpm7-29gg) Review the skill wording and habits and apply best practices from the security comunity, known CVE way of wording, specifying things. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed in |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Revokes gh-aw versions affected by GHSA-8h78-hpm7-29gg and adds reusable advisory-handling guidance.
Changes:
- Blocks versions
v0.82.8–v0.85.3. - Documents upgrade remediation.
- Adds compatibility schema validation coverage.
Show a summary per file
| File | Description |
|---|---|
.github/aw/compat.json |
Adds affected versions to the blocklist. |
.github/aw/compat.md |
Documents impact and remediation. |
.github/skills/security-advisory-compat-enforcer/SKILL.md |
Adds advisory enforcement guidance. |
.github/skills/agentic-workflows/SKILL.md |
Registers compatibility documentation. |
pkg/linters/compat_schema_test.go |
Validates compatibility configuration against its schema. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Balanced
| { | ||
| "$schema": "./compat.schema.json", | ||
| "blockedVersions": [], | ||
| "blockedVersions": [ |
There was a problem hiding this comment.
Agreed, the PR description was inaccurate. The implemented policy is: blockedVersions enumerates the exact affected range v0.82.8–v0.85.3 (per GHSA-8h78-hpm7-29gg), minimumVersion stays at v0.65.3, and minRecommendedVersion is now v0.85.4 for the upgrade nudge. I'll update the PR title/description to reflect this.
|
@copilot fix https://github.com/github/gh-aw/actions/runs/32980123710/job/98215139311?pr=55796 and run pr-finisher skill |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ndedVersion, add boundary test Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot PR #55796 still needs follow-up.
|
Status update:
I don't have permissions to resolve GitHub review threads or edit the PR title/description directly from this environment — those need a maintainer action. All code-level asks are done and pushed. |
|
@copilot PR #55796 still needs follow-up.
|
…-json-to-0853 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Refreshed the branch: merged 12 new commits from All actionable review feedback from automated reviewers was already addressed and replied to in prior commits ( Remaining items (resolving GitHub review threads, editing the PR title/description) require repo-write actions this agent doesn't have access to in this sandbox — those need a maintainer. |
|
Category: chore; risk: high; score: 75/100 (impact 40/50, urgency 21/30, quality 14/20); recommended action: fast_track; CI: pending/unknown; review signal: 12 reviews, 26 issue comments.
|
|
Category: chore | Risk: high | Score: 74 (impact 40 + urgency 22 + quality 12) | Action: fast_track | Batch: permissions-security | Note: Security compatibility floor update.
|
Updates the compatibility policy for GHSA-8h78-hpm7-29gg and adds reusable guidance for translating security advisories into targeted compatibility changes.
Changes
Compatibility enforcement
minimumVersionfromv0.65.3tov0.85.3.Advisory workflow
security-advisory-compat-enforcer.