Skip to content

Enforce gh-aw v0.85.3 security compatibility floor - #55796

Open
pelikhan with Copilot wants to merge 14 commits into
mainfrom
copilot/update-combat-json-to-0853
Open

Enforce gh-aw v0.85.3 security compatibility floor#55796
pelikhan with Copilot wants to merge 14 commits into
mainfrom
copilot/update-combat-json-to-0853

Conversation

Copilot AI commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Updates the compatibility policy for GHSA-8h78-hpm7-29gg and adds reusable guidance for translating security advisories into targeted compatibility changes.

Changes

  • Compatibility enforcement

    • Raises minimumVersion from v0.65.3 to v0.85.3.
    • Preserves blocked, recommended, and agent compatibility policies.
  • Advisory workflow

    • Adds security-advisory-compat-enforcer.
    • Requires evidence-backed policy selection, monotonic version floors, schema validation, and preservation of unrelated fields.
"minimumVersion": "v0.85.3"

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot can you ban the range of releases flagged by the advisory?

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot can you ban the range of releases flagged by the advisory?

Addressed in 313ee1e: blockedVersions now enumerates every affected release from v0.82.8 through v0.85.2, while the general minimum remains v0.65.3.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot v0.85.4 it's the first valid version that doesn't contain such a misreading of the advisory—or is the advisory…

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot v0.85.4 it's the first valid version that doesn't contain such a misreading of the advisory—or is the advisory…

Corrected in b435280: v0.85.3 is now blocked, so v0.85.4 is the first allowed release.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot update the skill to make sure to run a schema validator on compat.json (there should be a task in main), also maintain a compat.md that lists why these versions are blocked linking to the advisories

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot update the skill to make sure to run a schema validator on compat.json (there should be a task in main), also maintain a compat.md that lists why these versions are blocked linking to the adv...

Addressed in b3644de: the skill now requires the compatibility CI task plus Draft 7 schema validation, and .github/aw/compat.md documents the blocked v0.82.8v0.85.3 range with the GHSA link.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot ensure that there is a unit test that validate that compat.json is valid w.r.t to the compat schema.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot the skill should tell the agent to provide remediation instructions, similarly to the advisory (see updated content in https://github.com/github/gh-aw/security/advisories/GHSA-8h78-hpm7-29gg)

Review the skill wording and habits and apply best practices from the security comunity, known CVE way of wording, specifying things.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot ensure that there is a unit test that validate that compat.json is valid w.r.t to the compat schema.

Addressed in e5e0922: added TestCompatJSONConformsToSchema, which compiles .github/aw/compat.schema.json and validates .github/aw/compat.json against it.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Revokes gh-aw versions affected by GHSA-8h78-hpm7-29gg and adds reusable advisory-handling guidance.

Changes:

  • Blocks versions v0.82.8v0.85.3.
  • Documents upgrade remediation.
  • Adds compatibility schema validation coverage.
Show a summary per file
File Description
.github/aw/compat.json Adds affected versions to the blocklist.
.github/aw/compat.md Documents impact and remediation.
.github/skills/security-advisory-compat-enforcer/SKILL.md Adds advisory enforcement guidance.
.github/skills/agentic-workflows/SKILL.md Registers compatibility documentation.
pkg/linters/compat_schema_test.go Validates compatibility configuration against its schema.

Review details

  • Files reviewed: 5/5 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread .github/aw/compat.md Outdated
Comment thread .github/aw/compat.json
{
"$schema": "./compat.schema.json",
"blockedVersions": [],
"blockedVersions": [

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the PR description was inaccurate. The implemented policy is: blockedVersions enumerates the exact affected range v0.82.8v0.85.3 (per GHSA-8h78-hpm7-29gg), minimumVersion stays at v0.65.3, and minRecommendedVersion is now v0.85.4 for the upgrade nudge. I'll update the PR title/description to reflect this.

@pelikhan

Copy link
Copy Markdown
Collaborator

Copilot AI and others added 2 commits August 26, 2026 18:22
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ndedVersion, add boundary test

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot PR #55796 still needs follow-up.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 9.03 AIC · ⌖ 8.03 AIC · ⊞ 8.7K ·
Comment /souschef to run again

Copilot AI commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@copilot PR #55796 still needs follow-up.

  • Please address the outstanding requested-changes reviews from automated reviewers....

Status update:

  • The technical concerns raised by the automated CHANGES_REQUESTED reviews (missing minRecommendedVersion bump, boundary tests, broken remediation link) were already addressed in b2d52b0 and replied to on each thread.
  • The minimumVersion vs blockedVersions semantics question was resolved per @pelikhan's explicit direction in this PR's history (ban the exact affected range, corrected to include v0.85.3): blockedVersions enumerates v0.82.8v0.85.3, minimumVersion stays v0.65.3, minRecommendedVersion is now v0.85.4.
  • Fixed the failing job (https://github.com/github/gh-aw/actions/runs/32980123710/job/98215139311, TestFallbackAWFilesMatchesLocalAWDirectory) by adding compat.md to the embedded fallback file list.
  • Ran the full pr-finisher validation pass (make agent-report-progress, code_review, codeql_checker) — all pass clean with no new findings.

I don't have permissions to resolve GitHub review threads or edit the PR title/description directly from this environment — those need a maintainer action. All code-level asks are done and pushed.

Copilot AI requested a review from gh-aw-bot August 26, 2026 22:47
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot PR #55796 still needs follow-up.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 13.9 AIC · ⌖ 8.09 AIC · ⊞ 8.7K ·
Comment /souschef to run again

…-json-to-0853

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@copilot PR #55796 still needs follow-up.

  • Please address the outstanding requested-changes reviews from automated reviewers....

Refreshed the branch: merged 12 new commits from main (a6e0791), no conflicts, make agent-report-progress passes clean after the merge.

All actionable review feedback from automated reviewers was already addressed and replied to in prior commits (b2d52b0): minRecommendedVersion bumped to v0.85.4, boundary test added, broken remediation link fixed, and the minimumVersion/blockedVersions semantics question clarified per the maintainer's explicit direction earlier in this thread.

Remaining items (resolving GitHub review threads, editing the PR title/description) require repo-write actions this agent doesn't have access to in this sandbox — those need a maintainer.

@github-actions

Copy link
Copy Markdown
Contributor

Category: chore; risk: high; score: 75/100 (impact 40/50, urgency 21/30, quality 14/20); recommended action: fast_track; CI: pending/unknown; review signal: 12 reviews, 26 issue comments.

Generated by 🔧 PR Triage Agent · copilot · mai10 · 13.5 AIC · ⌖ 2.44 AIC · ⊞ 16.6K ·

@github-actions

Copy link
Copy Markdown
Contributor

Category: chore | Risk: high | Score: 74 (impact 40 + urgency 22 + quality 12) | Action: fast_track | Batch: permissions-security | Note: Security compatibility floor update.

Generated by 🔧 PR Triage Agent · copilot · mai10 · 17.8 AIC · ⌖ 2.49 AIC · ⊞ 16.6K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants