-
Notifications
You must be signed in to change notification settings - Fork 512
Design Decision Gate: prevent runaway agent loops from nonexistent skill/tool drift #56314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+29
−4
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
207a465
Initial plan
Copilot ede7631
fix: tighten design-decision-gate instructions to avoid runaway turns
Copilot 36a3c4e
fix: restore ADR inline skill block and explicit terminator
Copilot a9f1d60
fix: keep inline skill EOF boundary implicit
Copilot 4f1663e
test: cover implicit EOF inline-skill parsing
Copilot d5f774c
Merge branch 'main' into copilot/fix-failing-github-actions-job
pelikhan cd44c47
test: prevent Getwd stub races
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/diagnosing-bugs] The deleted comment was load-bearing documentation — it explained why an explicit
## end skill:close-marker is required (to prevent the next import's heading from being swallowed). The new assertions test the behaviour, but future readers lose the rationale.💡 Suggestion
Re-add the explanation as a code comment above the new assertions:
Keeping "why" alongside "what" lets the test act as a living specification.
@copilot please address this.