Skip to content

Harden Docker scanner exec paths against argv/path injection #56333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Aug 27, 2026
+5 −0
Merged

Harden Docker scanner exec paths against argv/path injection #56333

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff73ec4
Initial plan
Copilot Aug 27, 2026
eef71ab
Harden docker scanner command argument validation
Copilot Aug 27, 2026
fbf5514
Polish grype validation error context
Copilot Aug 27, 2026
640ba13
Fix Docker scanner validation regressions
Copilot Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/cli/zizmor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,11 @@ func buildZizmorCommand(lockFiles []string) (cmd *exec.Cmd, relPaths []string, d
if err != nil {
return nil, nil, nil, fmt.Errorf("zizmor scanner image reference %q is invalid; expected a registry reference. Example: ghcr.io/owner/image:tag: %w", ZizmorImage, err)
}
for _, containerPath := range containerPaths {
if err := validateExecArgument(containerPath); err != nil {
return nil, nil, nil, fmt.Errorf("invalid zizmor scan path argument %q: %w", containerPath, err)
}
}
dockerArgs = zizmorDockerArgs(zizmorImageRef, volumeMount, containerPaths)

// #nosec G204 -- dockerPath is resolved from the allowlisted executable name "docker" via
Expand Down