Skip to content

Clarify prerelease upgrade downgrade guidance - #56351

Open
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/update-upgrade-command-behavior
Open

Clarify prerelease upgrade downgrade guidance#56351
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/update-upgrade-command-behavior

Conversation

Copilot AI commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

A stable-channel upgrade from a newer local prerelease returns to the latest stable release. The notice now makes that downgrade explicit and points users to the prerelease channel.

  • Upgrade guidance

    • States that omitting --pre-releases downgrades to the latest stable release.
    • Directs users to gh aw upgrade --pre-releases for the latest prerelease.
  • Coverage and release note

    • Updates the prerelease guidance test.
    • Adds a patch changeset.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan August 27, 2026 13:29
@pelikhan
pelikhan marked this pull request as ready for review August 27, 2026 14:51
Copilot AI balanced review requested due to automatic review settings August 27, 2026 14:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Clarifies prerelease upgrade messaging and records the user-facing change.

Changes:

  • Warns about an apparent stable-channel downgrade.
  • Updates notice expectations and adds a patch changeset.
Show a summary per file
File Description
pkg/cli/update_extension_check.go Revises prerelease guidance.
pkg/cli/update_extension_check_test.go Updates expected notice text.
.changeset/patch-clarify-prerelease-upgrade-guidance.md Adds release-note metadata.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Balanced

return []string{
fmt.Sprintf("Current gh-aw version %s is newer than the latest stable release %s.", renderReleaseVersion(currentVersion), renderReleaseVersion(latestStable)),
"Run `gh aw upgrade --pre-releases` to check for newer pre-releases.",
fmt.Sprintf("Current gh-aw version %s is newer than the latest stable release %s; upgrading without --pre-releases would downgrade to that release.", renderReleaseVersion(currentVersion), renderReleaseVersion(latestStable)),
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

No ADR enforcement needed: PR #56351 does not have the implementation label and has only 4 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #56351

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /grill-with-docs — no issues found.

The messaging change is clear and accurate: it now explicitly warns users that omitting --pre-releases will downgrade to the latest stable release, and correctly redirects them to the prerelease channel. The test is updated in sync with the implementation. Changeset is appropriately scoped as patch.

✅ Approved.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet46 · 13.7 AIC · ⌖ 9.72 AIC · ⊞ 7.6K
Comment /matt to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clarified messages are accurate and more actionable. The first line now explicitly warns that upgrading without --pre-releases would downgrade to the latest stable release — the key info previously missing. The second line is tightened appropriately. Tests updated to match. LGTM.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · copilot · sonnet46 · 14.3 AIC · ⌖ 9.04 AIC · ⊞ 6.2K

@github-actions

Copy link
Copy Markdown
Contributor

Comment Memory

reviewed_at: 2026-08-27T15:12:00Z
review_event: COMMENT
top_themes:
  - no actionable issues in changed lines
  - wording clarification matches test updates
files_reviewed:
  - .changeset/patch-clarify-prerelease-upgrade-guidance.md
  - pkg/cli/update_extension_check.go
  - pkg/cli/update_extension_check_test.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · pi · gpt54 · 2.56 AIC · ⌖ 6.86 AIC · ⊞ 7K ·
Comment /review to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable issues in the changed lines. The implementation is only tightening user-facing wording, the updated text now matches the actual stable-vs-prerelease guidance, and the test was updated in lockstep.

Review notes
  • The existing concern on this PR is valid: the notice text still talks about what an upgrade would do, even though this code path only emits a notice and returns.
  • This patch does not introduce a new correctness or performance regression beyond that pre-existing behavior.
  • The changeset scope and test update are consistent with the wording-only change.

🔎 Code quality review by PR Code Quality Reviewer · pi · gpt54 · 2.56 AIC · ⌖ 6.86 AIC · ⊞ 7K
Comment /review to run again

@github-actions github-actions Bot mentioned this pull request Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants