Clarify prerelease upgrade downgrade guidance#56351
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Clarifies prerelease upgrade messaging and records the user-facing change.
Changes:
- Warns about an apparent stable-channel downgrade.
- Updates notice expectations and adds a patch changeset.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/update_extension_check.go |
Revises prerelease guidance. |
pkg/cli/update_extension_check_test.go |
Updates expected notice text. |
.changeset/patch-clarify-prerelease-upgrade-guidance.md |
Adds release-note metadata. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
| return []string{ | ||
| fmt.Sprintf("Current gh-aw version %s is newer than the latest stable release %s.", renderReleaseVersion(currentVersion), renderReleaseVersion(latestStable)), | ||
| "Run `gh aw upgrade --pre-releases` to check for newer pre-releases.", | ||
| fmt.Sprintf("Current gh-aw version %s is newer than the latest stable release %s; upgrading without --pre-releases would downgrade to that release.", renderReleaseVersion(currentVersion), renderReleaseVersion(latestStable)), |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. No ADR enforcement needed: PR #56351 does not have the implementation label and has only 4 new lines of code in business logic directories (threshold: 100).
|
|
✅ Ponytail Reviewer completed successfully! Lean already. Ship.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — no issues found.
The messaging change is clear and accurate: it now explicitly warns users that omitting --pre-releases will downgrade to the latest stable release, and correctly redirects them to the prerelease channel. The test is updated in sync with the implementation. Changeset is appropriately scoped as patch.
✅ Approved.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet46 · 13.7 AIC · ⌖ 9.72 AIC · ⊞ 7.6K
Comment /matt to run again
There was a problem hiding this comment.
The clarified messages are accurate and more actionable. The first line now explicitly warns that upgrading without --pre-releases would downgrade to the latest stable release — the key info previously missing. The second line is tightened appropriately. Tests updated to match. LGTM.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · copilot · sonnet46 · 14.3 AIC · ⌖ 9.04 AIC · ⊞ 6.2K
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment.
|
There was a problem hiding this comment.
No actionable issues in the changed lines. The implementation is only tightening user-facing wording, the updated text now matches the actual stable-vs-prerelease guidance, and the test was updated in lockstep.
Review notes
- The existing concern on this PR is valid: the notice text still talks about what an upgrade would do, even though this code path only emits a notice and returns.
- This patch does not introduce a new correctness or performance regression beyond that pre-existing behavior.
- The changeset scope and test update are consistent with the wording-only change.
🔎 Code quality review by PR Code Quality Reviewer · pi · gpt54 · 2.56 AIC · ⌖ 6.86 AIC · ⊞ 7K
Comment /review to run again
A stable-channel upgrade from a newer local prerelease returns to the latest stable release. The notice now makes that downgrade explicit and points users to the prerelease channel.
Upgrade guidance
--pre-releasesdowngrades to the latest stable release.gh aw upgrade --pre-releasesfor the latest prerelease.Coverage and release note